Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 272
  • Merge Requests 34
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !463

Open
Opened 6 hours ago by Marcelo Rivera@eiennohi
Report abuse

Allow users to permanently hide "share" buttons in settings

  • Overview 2
  • Commits 4
  • Pipelines 2
  • Changes 5
0/2 threads resolved

closes #1330

Edited 5 hours ago by Marcelo Rivera
Request to merge feat/hide-share-buttons into master
Open in Web IDE
Pipeline #116939984 passed for 671648e2 on feat/hide-share-buttons
          Requires 2 more approvals from Deployers and QA. Approved by
          Olivia Madrid
          Martin Santangelo Rami Albatal Brian Hatchet Emiliano Balbuena Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1330

          Deletes source branch

          • Marcelo Rivera @eiennohi mentioned in merge request front!776 6 hours ago

            mentioned in merge request front!776

          • Marcelo Rivera @eiennohi added 1 commit 6 hours ago

            added 1 commit

            • 671648e2 - (fix): lint

            Compare with previous version

          • Marcelo Rivera @eiennohi changed the description 5 hours ago

            changed the description

          • Olivia Madrid @omadrid approved this merge request 2 hours ago

            approved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 20 minutes ago
            Core/Blogs/Blog.php
            327 332 */
            328 333 public function getOwnerObj()
            329 334 {
            330 if (!$this->ownerObj && $this->ownerGuid) {
            335 if ($this->fullExport || (!$this->ownerObj && $this->ownerGuid)) {
            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 20 minutes ago
              Developer

              Why are we restricting this to full export? The previous code handled more instances where we reconstituted the owner object if it wasn't there.

            • Please register or sign in to reply
          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 18 minutes ago
            Entities/User.php
            922 941 $export['eth_wallet'] = $this->getEthWallet() ?: '';
            923 942 $export['rating'] = $this->getRating();
            924 943
            944 $export['hide_share_buttons'] = $this->getHideShareButtons();
            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 18 minutes ago
              Developer

              I see we're handling blogs and newsfeed, does this work for images / videos?

            • Please register or sign in to reply
          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Lock merge request
          Unlocked
          9
          9 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!463