Allow users to permanently hide "share" buttons in settings
0/3
threads resolved
Request to merge
feat/hide-share-buttons
into
master
changed the description
![Brian Hatchet](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
DeveloperOk, finally got the review site working with the latest and greatest changes. Unfortunately, the share button disabling is not working
- Go to settings
- Uncheck share settings
- Save
- Reload settings, note how it's properly unchecked
- Go to the feed
- Click on the date of a single entity
- Share buttons are still there
Note my settings are confirmed
added scoped label
265 cy.get('.m-btn--action').contains('Save').click().wait('@postSettings').then(xhr => { 266 expect(xhr.status).to.equal(200); 267 expect(xhr.response.body.status).to.equal('success'); 268 }); 269 270 cy.wait(1000); 271 272 cy.visit('/blog/edit/new'); 273 274 uploadAvatar(); 275 createBlogPost(title, body, true); 276 277 cy.get('m-social-icons').should('not.exist'); 278 deleteBlogPost(); 279 }); 280 - Developer
Need a spec test to make sure the share bar goes away when this setting is turned off.
327 327 [url]="siteUrl + 'media/' + entity.guid" 328 328 [title]="entity.title || ''" 329 329 [embed]="entity" 330 *ngIf="entity && !attachment.shouldBeBlurred(entity)" 330 *ngIf=" 331 entity && 332 !attachment.shouldBeBlurred(entity) && 333 !entity.ownerObj?.hide_share_buttons - Developer
What if they are looking at someone else's entity. We need to check the logged in user's settings, not the entity
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
