Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 406
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !764

Open
Opened 5 days ago by Mark Harding@markeharding
Report abuse

New activity posts with fixed heights

  • Overview 1
  • Commits 17
  • Pipelines 15
  • Changes 60
0/1 thread resolved

Closes #2511

Feature flag activity-v2--single-page

Edited 1 hour ago by Brian Hatchet
Request to merge feat/2511-activity-v2 into master
The source branch is 8 commits behind the target branch
Open in Web IDE
Pipeline #115874648 passed with warnings for 497fa48c on feat/2511-activity-v2
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Xander Miller Marcelo Rivera Martin Santangelo Rami Albatal
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2511

              Deletes source branch

              • Mark Harding @markeharding added 1 commit 5 days ago

                added 1 commit

                • a11ce73d - (fix): aot bad variables

                Compare with previous version

              • Mark Harding @markeharding added 3 commits 4 days ago

                added 3 commits

                • 30a38206 - (fix): readmore now works for activity
                • 2cb00b0f - (chore): introduce feature flag for new activity component on full view
                • 264627a5 - (feat): implements reminds with fixed Height

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 4 days ago

                added 1 commit

                • f738f5c8 - (fix): failing tests

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 4 days ago

                added 1 commit

                • 3e7a1f9b - (fix): failing tests

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 4 days ago

                added 1 commit

                • ad2261e2 - (fix): comments overflowing when fixed height

                Compare with previous version

              • Mark Harding @markeharding unmarked as a Work In Progress 4 days ago

                unmarked as a Work In Progress

              • Mark Harding @markeharding added 13 commits 3 days ago

                added 13 commits

                • ad2261e2...14445689 - 12 commits from branch master
                • 497fa48c - Merge branch 'master' of https://gitlab.com/Minds/front into feat/2511-activity-v2

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 hour ago

                changed the description

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 2 minutes ago
                src/app/modules/newsfeed/single/single.component.ts
                177 191 delete(activity) {
                178 192 this.router.navigate(['/newsfeed']);
                179 193 }
                194
                195 get showLegacyActivity(): boolean {
                196 return (
                197 this.editing || !this.featuresService.has('activity-v2--single-page')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 2 minutes ago
                  Developer

                  https://gitlab.com/minds/engine/-/blob/master/Core/Features/Provider.php#L46

                  This needs an engine addition so we can turn on the FF via unleash

                • Please register or sign in to reply
              • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label 1 minute ago

                added scoped label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!764