Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 406
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !775

Open
Opened 18 minutes ago by Ben Hayward@benhayward.ben
Report abuse

Upgraded Plyr #2572

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Closes #2572,

Summary

Plyr has put forth an update that should address the volume control going missing for some users.

Removed logic to hide/show volume controls based on audio track detection due to it's problematic nature. If you want to hide volume control, use the controls option to do so.

https://github.com/sampotts/plyr/releases

Steps to test

  1. Check video player all working properly
  2. Make sure that you can see the volume control on Chrome and Firefox

Estimated Regression Scope

If there's a broken change, that is not in our control. Branch has been officially released.

Request to merge chore/plyr-upgrade-2572 into master
The source branch is 35 commits behind the target branch
Open in Web IDE
Pipeline #116680663 failed for d99379c4 on chore/plyr-upgrade-2572
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Xander Miller Marcelo Rivera Martin Santangelo Rami Albatal
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2572

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 18 minutes ago

                added scoped labels

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!775