Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 406
  • Merge Requests 65
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !774

Open
Opened 28 minutes ago by Ben Hayward@benhayward.ben
Report abuse

Posting before rich-embed completed shows unwanted attachment in new comment underneath #2418

  • Overview 0
  • Commits 7
  • Pipelines 1
  • Changes 12

Summary

Closes #2418

Original change on prod is that if you hit enter too quickly after posting a link, it will not post with the rich embed preview, but it will upload in a separate comment below after the comment is posted instead.

Behaviourally,

  • A user should be able to post a link without a rich embed
  • Once the user has posted, they should not see rich-embed in new window.

Steps to test

  1. Log in and go to a post
  2. Copy a link e.g. https://www.google.com/
  3. Paste it into a comment on the post and rapidly hit enter (do not wait for preview response)
  4. it should post without the preview, there should not be a new attachment that loads under the comment.
  5. Repeat with an invalid URL e.g. https://www.ks3fnj3n9.com
  6. Try typing a url
  7. Ensure when you wait for the rich-embed to come back, it does post.

Estimated Regression Scope

The area that this change impacts has been reduced; it should now, in the worst-case scenario mess something up only with rich-embeds.

Request to merge fix/premature-posting-2418 into master
The source branch is 22 commits behind the target branch
Open in Web IDE
Pipeline #116676014 running for 08af3266 on fix/premature-posting-2418
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Xander Miller Marcelo Rivera Martin Santangelo Rami Albatal
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2418

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 28 minutes ago

                added scoped labels

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!774