Sometimes an on-chain transaction fails. Should we show these on the wallet token transactions table? If yes, what should they look like?

Right now I just have a line going through the template text as a temporary fix.

assigned to @omadrid

assigned to @michaelfbradley

added scoped label

changed milestone to %Wallet Upgrade

changed title from to

changed the description

added scoped label

@michaelfbradley poke

Hey @omadrid - In my mind if a transaction failed to happen, it should be omitted from the transactions table.

Unless you think there is a use-case for displaying such information?

I would imagine a simple toast notification, as the transaction fails, informing the user the on-chain transfer failed should be enough.

Anyone got thoughts on this? cc @ottman @jotto141 @markeharding

If a transaction fails, the user should be informed, otherwise they may think it went through. Completed, Pending, Failed or something like that.

According to @markeharding, failures should only happen on very rare occasions, if ever...

Re: notifications - since the on-chain transfer takes up to 24 hours to be processed, the notification should live in the regular notifications pane, as opposed to ephemeral toast (unless failure cases are caught immediately? I'm not familiar with the tx processing flow - do you know, Mark?). It doesn't look like we currently have anything in the notifications template that is informing users that a transaction has failed.

Since on-chain tx notifications are out of scope I'm just going to omit the failed ones from the transactions table unless I hear otherwise.

@michaelfbradley @ottman @jotto141