Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !765

Open
Opened 4 days ago by Ben Hayward@benhayward.ben
Report abuse

Fixed broken E2E tests. #2539

  • Overview 7
  • Commits 4
  • Pipelines 4
  • Changes 10
5/5 threads resolved

Summary

Closes #2539

Fixes broken E2E tests against staging

Steps to test

  1. Checkout this branch and run in a shell cypress run --config baseUrl=https://www.minds.com,video=false --env username=<<<<username>>>>,password=<<<<password>>>>

Note 1 test WILL fail because the data-attr isn't on production yet.

Estimated Regression Scope

Only touched cypress and adds a data attr to HTML.

Edited 4 days ago by Ben Hayward
Request to merge fix/cypress-ssr-2539 into master
The source branch is 31 commits behind the target branch
Open in Web IDE
Pipeline #116638398 running for fcb78503 on fix/cypress-ssr-2539
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Xander Miller Marcelo Rivera Rami Albatal Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2539

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 4 days ago

                added scoped labels

              • Ben Hayward @benhayward.ben changed the description 4 days ago

                changed the description

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 days ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 days ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 days ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 days ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 days ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward @benhayward.ben added 1 commit 4 days ago

                added 1 commit

                • 07d10032 - Updated comment tests to reduce flake

                Compare with previous version

              • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::Awaiting Review label 3 days ago

                added scoped label and automatically removed label

              • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 2 days ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                added 1 commit

                • ebdd701c - Indentation fix that was causing within closure to be exited prematurely

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 45 minutes ago
                Developer

                Was all green lighting, now about 6 failing.

              • Ben Hayward @benhayward.ben added 1 commit 15 minutes ago

                added 1 commit

                • fcb78503 - Minor fixes

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 15 minutes ago
                Developer

                Captcha was throwing a spanner in the works.

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!765