Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 269
  • Merge Requests 33
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !369

Closed
Opened 3 months ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Cannot view paywalled content front#2004

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 3
0/1 thread resolved

Closes front#2004

Summary

Users could not view their own and others paywalled content. See the steps on the issue above and try it out for yourself.

Test

To test, I think we should test a variety of different media types, some with paywall and some without, from multiple accounts, and logged out, to ensure that everything is working.

Edited 3 months ago by Ben Hayward
Request to merge fix/media-paywall-2004 into master
Pipeline #89007449 passed for ed8d8021 on fix/media-paywall-2004
          Requires 3 more approvals from Devs, Deployers, and QA.
          Guy Thouret Emiliano Balbuena Marcelo Rivera Rami Albatal Martin Santangelo

          Closed by Ben Hayward 50 minutes ago

          The changes were not merged into master

          Did not close front#2004

          Deletes source branch

          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 months ago

            added scoped labels

          • Ben Hayward @benhayward.ben changed the description 3 months ago

            changed the description

          • Ben Hayward @benhayward.ben changed title from Sprint/PinkPanther: Cannot view paywalled content #2004 to Sprint/PinkPanther: Cannot view paywalled content front#2004 3 months ago

            changed title from : Cannot view paywalled content #2004 to : Cannot view paywalled content #2004

          • Ben Hayward @benhayward.ben changed the description 3 months ago

            changed the description

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 months ago
            Controllers/fs/v1/thumbnail.php
            18 18 exit;
            19 19 }
            20 20
            21 $featuresManager = new FeaturesManager;
            22
            23 if ($featuresManager->has('cdn-jwt')) {
            24 $signedUri = new Core\Security\SignedUri();
            25 $uri = (string) \Zend\Diactoros\ServerRequestFactory::fromGlobals()->getUri();
            26 if (!$signedUri->confirm($uri)) {
            27 exit;
            28 }
            21 $signedUri = new Core\Security\SignedUri();
            • Mark Harding
              Mark Harding @markeharding · 2 months ago
              Owner

              Public assets will not be signed to improve caching, so this check needs to be aware of that.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 months ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben closed 50 minutes ago

            closed

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Yellow Status::Requires Changes
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          user avatar
          Reference: minds/engine!369