New user menu
0/3
threads resolved
Request to merge
feat/user-menu-2427
into
epic/navigation-93
The source branch is 16 commits behind the target branch
Requires 2 more approvals from Deployers and QA. Approved by 
added scoped labels
changed title from to
changed target branch from
mastertoepic/navigation-93- Developer
added 78 commits
- 5263c95a - (wip): Server Side Rendering - work in progress
- 0efe142e - (chore): update with master - closes #2414 (closed)
- ca77f94f - (feat): working mvp of ssr
- 8dfc9b3a - (chore): performance bumps and browser specific delays
- 4399c6bc - (fix): failing spec tests
- 6a3dac72 - (fix): plotly fix, preparation for full server bundle and xsrf token re-introduced
- 14ab8c6e - (chore): ci configs
- 46f380ca - (fix): do not cache mobile incorrectly
- cfe0cb4a - (chore): some minor fixes for mobile improvements
- 361ef20c - (fix): do not show permissions if logged out
- 7cb62c62 - (chore): introduce build optimizer
- e9eee3a7 - (chore): preload material icons to improve first paint
- cd9272cd - (feat): meta service for SEO
- 2a206794 - (refactor): SEO from backend to frontend
- 09374b66 - (refactor): remove all uses of window.Minds
- c53c0aaa - (refactor): storage to cookies where applicable
- 4fda5f24 - (chore): allow for epic branches to push docker containers to aws
- 17b9abb5 - (fix): do not return null for nsfw reasons
- 7652c43d - (fix): remind asset links
- ff284a94 - (chore): do not stretch checkboxes
- 8d424529 - (fix): css should be loaded with correct asset path
- befad6c1 - (chore): remove icon preload
- eaf8a773 - (chore): cookie notice for all
- fc1185d7 - (chore): reduce plotly bundle
- af02de4b - (fix): nsfw cookie fix and notices.json credential error
- 3c5dae2d - (fix): wallet not loading when loaded server side
- 2118f305 - (fix): groups not loading server side
- b5b38399 - (fix): do not applu 100% width to checkboxes on homepage
- 26795138 - (fix): bad url for avatars
- b73ee1b0 - (chore): fix seo for blogs
- 98fd4fbe - (chore): temporary favicons
- eeb4b9e1 - (fix): groups create page not loading
- 9c600c2c - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
- 1363cae7 - (fix): canary assets path
- 96c066b0 - (fix): sockets issue
- 03a80ca3 - (fix): wrong path for canary bg
- a0ab3d48 - (fix): try not to render css for checkboxes
- b876854f - (fix): only show more groups if we have groups
- c3b33785 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
- 5a27ec5f - (feat): checkboxes on homepage
- a4d3e5e9 - (chore): update local build and serve scripts
- 95c2bfe7 - (fix): pro sites should wait for configs to be resolved
- 3a90b3dc - (fix): date dropdown should be in common posdt master merge
- adb6015c - (fix): reset router if pro
- f15627e1 - (fix): pro fixes
- 176a3c8f - (chore): move sentry to diagnostics service
- fc6a8b2e - (chore): sentry capture exception for pro
- 386ca4f8 - (fix): only render css bindings if in browser
- 2b3b74b3 - (chore): add Object type top platformId
- 75639885 - (fix): wrap session storage in try catch
- 7c5d306b - (fix): og tags incorrect
- da3ed520 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
- 13422e7a - [Sprint/HipsterHedgehog] (feat): ability to copy and paste images into posts and comments
- 2cb1c987 - Merge branch 'feat/copy-and-paste-images-in-posts' into 'master'
- 4f327c86 - Plyr play error
- 184c0f46 - Merge branch 'fix/autoplay-bug-2377' into 'master'
- 2809d08f - (chore): adds in production branch to be able to deploy to production
- 5fede3a6 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
- 145a730f - (chore): some small ci changes to test production pipeline works with SSR
- 225dc6f3 - (chore): allow for master to hit preprod
- 6b1b3271 - Modal pager fixes
- c6474453 - Merge branch 'fix/modal-pager-sync' into 'production'
- ff63f69d - Merge branch 'fix/modal-pager-sync' into 'production'
- fae30718 - Search period defaults and sort bar tweaks
- 410e752c - Merge branch 'chore/default-search-period' into 'master'
- 2261e73f - (chore): remove review dependency
- 5ffd58f5 - Merge branch 'production' of https://gitlab.com/Minds/front
- 44667f0d - (chore): bring sandbox helm chart branch to master
- fd261feb - (fix): remind preview cdn url - fixes #2531 (closed)
- 6fc73b99 - New Channel Registration, Signup button remains disabled
- 759cb8aa - Merge branch 'fix/register-issue-2527' into 'master'
- 6d761b80 - Merge remote-tracking branch 'upstream/master' into feat/navigation-superstructure
- 3890c40a - (fix): remove references to window.Minds
- 707b5089 - (fix): remove unused imports
- 380ea055 - (fix): only set .has-markers-sidebar if the new nav isn't enabled
- dcb2c350 - (feat): design for tablets
- 62bbcb33 - (feat): sidebar menu for mobile resolutions
- 5f998cb4 - Merge branch 'feat/navigation-superstructure' into feat/user-menu-2427
Toggle commit listapproved this merge request
1 1 <ng-container *ngIf="ready"> 2 2 <ng-container *ngIf="!isProDomain"> 3 <m-v2-topbar> 4 <ng-container search> 5 <m-search--bar [defaultSizes]="false"></m-search--bar> 6 </ng-container> 3 <ng-container *ngIf="useNewNavigation; else v2Topbar"> ![Brian Hatchet](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
DeveloperThis is getting really messy.
- Yank out the top-feeds feature flag, that's safe to sunset.
- If we have a pro, legacy, v2, v3 topbar, we need refactor them. It certainly seems like we can get rid of legacy
@markeharding any thoughts?
32 </ng-container> 33 </m-topbar> 34 </ng-template> 35 36 <m-sidebar--markers 37 [class.has-v2-navbar]="featuresService.has('top-feeds')" 38 ></m-sidebar--markers> 39 </ng-template> 18 40 </ng-container> 19 41 20 42 <m-body 21 [class.has-markers-sidebar]="session.isLoggedIn() && !isProDomain" 43 [class.has-markers-sidebar]=" 44 session.isLoggedIn() && 45 !isProDomain && 46 !featuresService.has('navigation-2020') - Developer
Just call this feature flag 'navigation'. It shouldn't be around that long.
33 60 </span> 34 61 </m-announcement> 35 62 <m-blockchain--wallet-address-notice></m-blockchain--wallet-address-notice> 36 <router-outlet></router-outlet> 63 <ng-container *ngIf="useNewNavigation; else oldLayout"> 64 <div class="m-grid"> - Developer
It looks like we can simplify a lot of this by refactoring the app.component containers into smaller containers.
Get rid of legacy (if that's possible) Load components for pro, v2 or v3 (which is also a terrible name)
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}