Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 402
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !754

Open
Opened 1 week ago by Marcelo Rivera@eiennohi
Report abuse

Remove duplicate bnjs

  • Overview 3
  • Commits 87
  • Pipelines 2
  • Changes 511
0/1 thread resolved

closes #2460

Testing Use whatever functionality that uses on-chain. bn.js is used in these places:

  • Withdraw
  • Transaction overlay (for checking the token balance)
  • Creating an on-chain boost
  • Showing the token balance in the wallet
Edited 6 days ago by Marcelo Rivera
Request to merge chore/remove-duplicate-bnjs into production
Open in Web IDE
Pipeline #116605345 failed for c369d57e on chore/remove-duplicate-bnjs
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Olivia Madrid Xander Miller Rami Albatal Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Deletes source branch

              • Marcelo Rivera @eiennohi added Squad::Blue scoped label 1 week ago

                added scoped label

              • Olivia Madrid @omadrid approved this merge request 1 week ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 1 week ago

                unapproved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                Developer

                Needs testing instructions, @eiennohi

              • Marcelo Rivera @eiennohi changed the description 6 days ago

                changed the description

                • Mark Harding
                  Mark Harding @markeharding · 3 days ago
                  Owner

                  We need to see the npm run bundle-report output to see if this has worked. I don't think using a third party node_modules path is an acceptable work around.

                • Collapse replies
                • Marcelo Rivera
                  Marcelo Rivera @eiennohi · 5 minutes ago
                  Developer

                  Just updated it to use our bn.js bundle, but I don't think this is totally safe either, as different libraries could be using different versions of this.

                  The bundle-report for the vendor bundle went from 7,43 MB to 6,93 MB

                • Please register or sign in to reply
              • Mark Harding @markeharding added Status::Requires Changes scoped label 3 days ago

                added scoped label

              • Marcelo Rivera @eiennohi added 86 commits 7 minutes ago

                added 86 commits

                • 5263c95a - (wip): Server Side Rendering - work in progress
                • 0efe142e - (chore): update with master - closes #2414 (closed)
                • ca77f94f - (feat): working mvp of ssr
                • 8dfc9b3a - (chore): performance bumps and browser specific delays
                • 4399c6bc - (fix): failing spec tests
                • 6a3dac72 - (fix): plotly fix, preparation for full server bundle and xsrf token re-introduced
                • 14ab8c6e - (chore): ci configs
                • 46f380ca - (fix): do not cache mobile incorrectly
                • cfe0cb4a - (chore): some minor fixes for mobile improvements
                • 361ef20c - (fix): do not show permissions if logged out
                • 7cb62c62 - (chore): introduce build optimizer
                • e9eee3a7 - (chore): preload material icons to improve first paint
                • cd9272cd - (feat): meta service for SEO
                • 2a206794 - (refactor): SEO from backend to frontend
                • 09374b66 - (refactor): remove all uses of window.Minds
                • c53c0aaa - (refactor): storage to cookies where applicable
                • 4fda5f24 - (chore): allow for epic branches to push docker containers to aws
                • 17b9abb5 - (fix): do not return null for nsfw reasons
                • 7652c43d - (fix): remind asset links
                • ff284a94 - (chore): do not stretch checkboxes
                • 8d424529 - (fix): css should be loaded with correct asset path
                • befad6c1 - (chore): remove icon preload
                • eaf8a773 - (chore): cookie notice for all
                • fc1185d7 - (chore): reduce plotly bundle
                • af02de4b - (fix): nsfw cookie fix and notices.json credential error
                • 3c5dae2d - (fix): wallet not loading when loaded server side
                • 2118f305 - (fix): groups not loading server side
                • b5b38399 - (fix): do not applu 100% width to checkboxes on homepage
                • 26795138 - (fix): bad url for avatars
                • b73ee1b0 - (chore): fix seo for blogs
                • 98fd4fbe - (chore): temporary favicons
                • eeb4b9e1 - (fix): groups create page not loading
                • 9c600c2c - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
                • 1363cae7 - (fix): canary assets path
                • 96c066b0 - (fix): sockets issue
                • 03a80ca3 - (fix): wrong path for canary bg
                • a0ab3d48 - (fix): try not to render css for checkboxes
                • b876854f - (fix): only show more groups if we have groups
                • c3b33785 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
                • 5a27ec5f - (feat): checkboxes on homepage
                • a4d3e5e9 - (chore): update local build and serve scripts
                • 95c2bfe7 - (fix): pro sites should wait for configs to be resolved
                • 3a90b3dc - (fix): date dropdown should be in common posdt master merge
                • adb6015c - (fix): reset router if pro
                • f15627e1 - (fix): pro fixes
                • 176a3c8f - (chore): move sentry to diagnostics service
                • fc6a8b2e - (chore): sentry capture exception for pro
                • 386ca4f8 - (fix): only render css bindings if in browser
                • 2b3b74b3 - (chore): add Object type top platformId
                • 75639885 - (fix): wrap session storage in try catch
                • 7c5d306b - (fix): og tags incorrect
                • da3ed520 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
                • 5fede3a6 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
                • 145a730f - (chore): some small ci changes to test production pipeline works with SSR
                • 225dc6f3 - (chore): allow for master to hit preprod
                • ff63f69d - Merge branch 'fix/modal-pager-sync' into 'production'
                • fae30718 - Search period defaults and sort bar tweaks
                • 410e752c - Merge branch 'chore/default-search-period' into 'master'
                • 2261e73f - (chore): remove review dependency
                • 5ffd58f5 - Merge branch 'production' of https://gitlab.com/Minds/front
                • 44667f0d - (chore): bring sandbox helm chart branch to master
                • fd261feb - (fix): remind preview cdn url - fixes #2531 (closed)
                • 6fc73b99 - New Channel Registration, Signup button remains disabled
                • 759cb8aa - Merge branch 'fix/register-issue-2527' into 'master'
                • 9c924ddb - (feat): implements captcha - #646 (closed)
                • a8ed91a5 - Merge branch 'feat/646-captcha' into 'master'
                • edbca40b - (fix): #2535 (closed) pass route params to server
                • 6968119e - Merge branch 'fix/2535-pass-through-queryparams' into 'master'
                • 443efc60 - (fix): couple issues when configs fails to load
                • c6310433 - (chore): add ssr to canary page
                • 43727865 - (fix): SEO for groups - closes #2543 (closed)
                • baeb58ce - Feature flags admin panel
                • c7d3caf5 - Merge branch 'goal/unleash-sync-namespaces' into 'master'
                • 061aed6d - Confirmation email template assets
                • c7ea83b1 - Merge branch 'goal/upgrade-confirmation-email' into 'master'
                • 60f8f62e - Ability to go to original channel page from a published pro site
                • cf8a0350 - Merge branch 'feat/link-to-channel-from-pro-site' into 'master'
                • ad7c5f83 - Uninstantiated observable in Sockets #2489 (closed)
                • 8c856a55 - Merge branch 'fix/sockets-rxjs-handling-errors-2489' into 'master'
                • 5398250e - (feat): adds in new color variables
                • 14445689 - (fix): experiments service sould be injected with cookieService not storage
                • 14293472 - (fix): do not cache for different domains
                • 0b7160e2 - (chore): set max memory of nodejs
                • 37f6a355 - (chore): reduce caching size and output stats
                • 181383d5 - Merge remote-tracking branch 'upstream/master' into chore/remove-duplicate-bnjs
                • c369d57e - (fix): use our bn.js

                Compare with previous version

                Toggle commit list
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Blue Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!754