Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 401
  • Merge Requests 64
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !772

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
Report abuse

Fix/url hashtag count #2361

  • Overview 0
  • Commits 8
  • Pipelines 1
  • Changes 17

Summary

Closes #2361

** note this MR includes the new installer changes, wait for that before merge **

Added in a check for whether the matching tag is located in a URL.

Steps to Test

This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:

  1. Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
  2. Try a URL with a hashtag in.
  3. Check the hashtags links go through to the correct place.
  4. Try to use the hashtag selector to bypass the limit
  5. Ensure when you add a tag it shows up in the selector

Estimated Regression Scope

This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag

Request to merge fix/url-hashtag-count into master
Open in Web IDE
Pipeline #116020377 failed for 0e69ebb8 on fix/url-hashtag-count
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet Rami Albatal Emiliano Balbuena Juan Manuel Solaro Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2361

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 1 hour ago

                added scoped label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!772