WIP: Fix email confirmation on SSR
0/2
threads resolved
Summary
Fix email confirmation not being triggered on SSR site
- Closes #2535 (closed)
Steps to test
- Go to review site
- Register a new user with a valid email address
- Go to your inbox and click the confirmation link/button
- Ensure the "Confirm your email" blue banner does not show
- Reload, and ensure the blue banner is still not showing
- Go to Menu > Settings > Email Confirmation
- Change your email to a valid email address
- Go to newsfeed. Ensure the blue banner appears again
- Go to your inbox and click the confirmation link/button
- Ensure the blue banner doesn't show
- Reload, and confirm the blue banner is still not showing
Estimated Regression Scope
- SSR server engine and bootstrap
- Email confirmation
Request to merge
fix/ssr-email-confirmation
into
master
Closed by
The changes were not merged into master
added scoped label
added 1 commit
- 4aa92b4c - (wip): Use value at instantiation time; fix test
76 76 provideModuleMap, 77 77 } = require('@nguniversal/module-map-ngfactory-loader'); 78 78 79 app.engine( 80 'html', 81 ngExpressEngine({ 79 app.engine('html', (_, options, callback) => { 80 const engine = ngExpressEngine({ 82 81 bootstrap: AppServerModuleNgFactory, 83 providers: [provideModuleMap(LAZY_MODULE_MAP)], 84 }) 85 ); 82 providers: [ 83 { ![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
OwnerWhy are we doing this here vs on L150?
76 76 provideModuleMap, 77 77 } = require('@nguniversal/module-map-ngfactory-loader'); 78 78 79 app.engine( 80 'html', 81 ngExpressEngine({ 79 app.engine('html', (_, options, callback) => { 80 const engine = ngExpressEngine({ 82 81 bootstrap: AppServerModuleNgFactory, 83 providers: [provideModuleMap(LAZY_MODULE_MAP)], 84 }) 85 ); 82 providers: [ 83 { - Owner
Also, it's not just SSR that requires it, it's the browser too.
closed
