Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 397
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #2160

Closed
Open
Opened 3 months ago by Bill Ottman@ottman:dragon_face:0 of 2 tasks completed0/2 tasks
Report abuse New issue

Enter key goes to full search results, not to users

search ottman, autocomplete works, but if i press enter the feed is empty.

no one would ever know to tap the channel filter. this happens a lot.

search should ALWAYS show results if they are available in another filter.

As an interim fix until we have the new search page and the combined results, hitting enter on the search box should

  • show a searched feed if there are results
  • load the channel search if there are channel results but no activities that match
Edited 1 month ago by Brian Hatchet

Linked issues
0

  • Discussion 9
  • Designs 0
  • Bill Ottman :dragon_face: @ottman added Platform::Browser Priority::1 - High Product::Search Status::Backlog Type::Feature scoped labels 3 months ago

    added scoped labels

  • Mark Harding @markeharding moved from engine#1051 (moved) 3 months ago

    moved from engine#1051 (moved)

  • Mark Harding @markeharding changed title from Default search broken to Enter key goes to full search results, not to users 3 months ago

    changed title from to

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Validation scoped label and automatically removed Status::Backlog label 2 months ago

    added scoped label and automatically removed label

  • Bill Ottman :dragon_face: @ottman added Type::Bug scoped label and automatically removed Type::Feature label 2 months ago

    added scoped label and automatically removed label

  • Bill Ottman :dragon_face: @ottman changed the description 2 months ago

    changed the description

  • Bill Ottman :dragon_face: @ottman assigned to @benhayward.ben 2 months ago

    assigned to @benhayward.ben

    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
      Developer

      @ottman is this on mobile? Web appears to be functioning exactly as you describe, type in ottman and a hover card shows search results and hitting enter actually searches

    • Collapse replies
    • Bill Ottman
      Bill Ottman :dragon_face: @ottman · 1 month ago
      Owner

      Correct only web, but the problem with mobile is that if you say search 'subverse' under the video filter, nothing comes up and most people would not realize to switch the filter.

    • Please register or sign in to reply
  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Follow Up scoped label and automatically removed Status::Validation label 1 month ago

    added scoped label and automatically removed label

  • Bill Ottman :dragon_face: @ottman added Status::Backlog scoped label and automatically removed Status::Follow Up label 1 month ago

    added scoped label and automatically removed label

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 1 month ago
    Owner

    Let's get this dealt with. Small change, high impact.

  • Bill Ottman :dragon_face: @ottman added Sprint::01/01 - Xerothermic Xenarthra scoped label 1 month ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Planning Breakdown scoped label and automatically removed Status::Backlog label 1 month ago

    added scoped label and automatically removed label

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
    Developer

    This issue is still a little muddy. On web, when I hit enter, it searches for activities containing the word "subverse", but it sounds like you want it to load the subverse channel specifically?

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @ottman 1 month ago

    assigned to @ottman

  • Brian Hatchet :speech_balloon: @brianhatchet unassigned @benhayward.ben 1 month ago

    unassigned @benhayward.ben

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 1 month ago
    Owner

    I mean this bleeds into Michael's new search mocks which provide both channels and content and groups in results. People would never currently know to switch the filter to channels. Maybe the temp hack is to auto roll over to channels if theres no content.

    Edited by Bill Ottman 1 month ago
  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 month ago

    changed the description

  • Bill Ottman :dragon_face: @ottman unassigned @ottman 1 month ago

    unassigned @ottman

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/15 - Youthful Yabby scoped label and automatically removed Sprint::01/01 - Xerothermic Xenarthra label 1 month ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 4 weeks ago

    assigned to @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint::01/15 - Youthful Yabby 4 weeks ago

    changed milestone to %Sprint::01/15 - Youthful Yabby

  • Brian Hatchet :speech_balloon: @brianhatchet changed due date to January 28, 2020 4 weeks ago

    changed due date to January 28, 2020

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 4 4 weeks ago

    changed weight to 4

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 4h 4 weeks ago

    changed time estimate to 4h

  • Brian Hatchet :speech_balloon: @brianhatchet added to epic &109 4 weeks ago

    added to epic &109

  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Yellow scoped label 3 weeks ago

    added scoped label

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::Planning Breakdown label 3 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 weeks ago
    Developer

    I think that this will require some architectural discussion. The searchbar its self doesn't load the entities, it just navigates to URLs in discovery.

    I guess the task is to add some logic to change from 'all' to 'channels' in discovery when there are no results.

    Issues with this:

    • The user will be left in channels
    • Do we show groups after if no channels either? Feels like daisy-chaining them is wrong but it is behaviour you would expect.
    • Request spam

    Possible solution:

    Maybe we could return something like below from the api/v2/feeds/global/top/activities endpoint if no results are found for the search. So If all returns no results, we check for channels and groups on the back-end, then we then add nextType to the response to let the front-end know it can request that type instead.

    This would cut it down to 2 calls between client and server rather than 3 (channels / group)

    [
       "response": []
       "nextType": [channel]
    ]
    Edited by Ben Hayward 3 weeks ago
  • Ben Hayward @benhayward.ben added 1h of time spent at 2020-01-16 3 weeks ago

    added 1h of time spent at 2020-01-16

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
    Developer

    Moving this to planning break down for next sprint and getting Mark's input

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Planning Breakdown scoped label and automatically removed Status::Follow Up label 2 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet removed milestone 2 weeks ago

    removed milestone

  • Brian Hatchet :speech_balloon: @brianhatchet removed from epic &109 2 weeks ago

    removed from epic &109

  • Brian Hatchet :speech_balloon: @brianhatchet removed due date 2 weeks ago

    removed due date

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @markeharding 2 weeks ago

    assigned to @markeharding

  • Brian Hatchet :speech_balloon: @brianhatchet unassigned @benhayward.ben 2 weeks ago

    unassigned @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @brianhatchet 2 weeks ago

    assigned to @brianhatchet

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
    Developer

    @markeharding we need to come up with a game plan for combining search results and I need your help.

  • Brian Hatchet :speech_balloon: @brianhatchet removed Sprint::01/15 - Youthful Yabby label 2 weeks ago

    removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::02/12 Baritone Baboon scoped label 13 minutes ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @ottman 13 minutes ago

    assigned to @ottman

  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %Sprint::02/12 Bartone Baboon 13 minutes ago

    changed milestone to %Sprint::02/12 Bartone Baboon

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 12 minutes ago
    Developer

    @ottman This is the bug with the search. See Ben's feedback on the difficulties

Please register or sign in to reply
3 Assignees
Mark Harding's avatar
Bill Ottman's avatar
Brian Hatchet's avatar
none
Epic
None
Sprint::02/12 Bartone Baboon
Milestone
Sprint::02/12 Bartone Baboon
Time tracking
Spent 1h
Est 4h
None
Due date
None
7
Labels
Platform::Browser Priority::1 - High Product::Search Sprint::02/12 Baritone Baboon Squad::Yellow Status::Planning Breakdown Type::Bug
4
Weight
4
Confidentiality
Not confidential
Lock issue
Unlocked
4
4 participants
user avatar
user avatar
user avatar
user avatar
Reference: minds/front#2160