Enter key goes to full search results, not to users
search ottman, autocomplete works, but if i press enter the feed is empty.
no one would ever know to tap the channel filter. this happens a lot.
search should ALWAYS show results if they are available in another filter.
As an interim fix until we have the new search page and the combined results, hitting enter on the search box should
- show a searched feed if there are results
- load the channel search if there are channel results but no activities that match
added scoped labels
moved from engine#1051 (moved)
changed title from to
added scoped label and automatically removed label
added scoped label and automatically removed label
changed the description
assigned to @benhayward.ben
- Developer
@ottman is this on mobile? Web appears to be functioning exactly as you describe, type in ottman and a hover card shows search results and hitting enter actually searches
- Owner
Correct only web, but the problem with mobile is that if you say search 'subverse' under the video filter, nothing comes up and most people would not realize to switch the filter.
added scoped label and automatically removed label
added scoped label and automatically removed label
- Owner
Let's get this dealt with. Small change, high impact.
added scoped label
added scoped label and automatically removed label
- Developer
This issue is still a little muddy. On web, when I hit enter, it searches for activities containing the word "subverse", but it sounds like you want it to load the subverse channel specifically?
assigned to @ottman
unassigned @benhayward.ben
- Owner
I mean this bleeds into Michael's new search mocks which provide both channels and content and groups in results. People would never currently know to switch the filter to channels. Maybe the temp hack is to auto roll over to channels if theres no content.
Edited by Bill Ottman changed the description
added scoped label and automatically removed label
assigned to @benhayward.ben
changed milestone to %Sprint::01/15 - Youthful Yabby
changed due date to January 28, 2020
changed weight to 4
changed time estimate to 4h
added to epic &109
added scoped label
added scoped label and automatically removed label
- Developer
I think that this will require some architectural discussion. The searchbar its self doesn't load the entities, it just navigates to URLs in discovery.
I guess the task is to add some logic to change from 'all' to 'channels' in discovery when there are no results.
Issues with this:
- The user will be left in channels
- Do we show groups after if no channels either? Feels like daisy-chaining them is wrong but it is behaviour you would expect.
- Request spam
Possible solution:
Maybe we could return something like below from the api/v2/feeds/global/top/activities endpoint if no results are found for the search. So If
all
returns no results, we check for channels and groups on the back-end, then we then addnextType
to the response to let the front-end know it can request that type instead.This would cut it down to 2 calls between client and server rather than 3 (channels / group)
[ "response": [] "nextType": [channel] ]
Edited by Ben Hayward added 1h of time spent at 2020-01-16
- Developer
Moving this to planning break down for next sprint and getting Mark's input
added scoped label and automatically removed label
removed milestone
removed from epic &109
removed due date
assigned to @markeharding
unassigned @benhayward.ben
assigned to @brianhatchet
- Developer
@markeharding we need to come up with a game plan for combining search results and I need your help.
removed label
added scoped label
assigned to @ottman
changed milestone to %Sprint::02/12 Bartone Baboon
- Developer
@ottman This is the bug with the search. See Ben's feedback on the difficulties