Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 381
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !754

Open
Opened 6 days ago by Marcelo Rivera@eiennohi
Report abuse

Remove duplicate bnjs

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 3

closes #2460

Testing Use whatever functionality that uses on-chain. bn.js is used in these places:

  • Withdraw
  • Transaction overlay (for checking the token balance)
  • Creating an on-chain boost
  • Showing the token balance in the wallet
Edited 2 days ago by Marcelo Rivera
Request to merge chore/remove-duplicate-bnjs into production
Open in Web IDE
Pipeline #113980049 passed with warnings for 81aa29a4 on chore/remove-duplicate-bnjs
              Requires 2 more approvals from Deployers and QA. Approved by
              Olivia Madrid
              Mark Harding Ben Hayward Juan Manuel Solaro Brian Hatchet Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Deletes source branch

              • Marcelo Rivera @eiennohi added Squad::Blue scoped label 6 days ago

                added scoped label

              • Olivia Madrid @omadrid approved this merge request 6 days ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 3 days ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 3 days ago

                unapproved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 3 days ago
                Developer

                Needs testing instructions, @eiennohi

              • Marcelo Rivera @eiennohi changed the description 2 days ago

                changed the description

              • Mark Harding
                Mark Harding @markeharding · 49 minutes ago
                Owner

                We need to see the npm run bundle-report output to see if this has worked. I don't think using a third party node_modules path is an acceptable work around.

              • Mark Harding @markeharding added Status::Requires Changes scoped label 49 minutes ago

                added scoped label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Blue Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!754