Summary

Closes #2489 (closed)

Fixes an issue when the user is disconnected from the sockets server, before the error$ BehaviorSubject is instantiated in the connect hook.

Steps to test

1. Log in
2. Open a comment thread or make a new one
3. 2 choices: a. Set browser to offline mode, error message should show up and disapear when you reconnect (note if that fails, try B. It fails in my browser but works for others) b. Manually take the review site down for this MR, check the message comes up and disapears correctly and there are no errors in console.

Estimated Regression Scope

This change performs a minor refactor to all socket comms on the site.

added scoped labels

changed the description

changed target branch from master to production

marked as a Work In Progress

added 3 commits

• 384f1800...c6474453 - 2 commits from branch production
• a6c81bfd - Added in handling for events firing before connect hook finished

Compare with previous version

unmarked as a Work In Progress

@benhayward.ben Pipeline issues

mentioned in issue #2515

added 71 commits

• 5263c95a - (wip): Server Side Rendering - work in progress
• 0efe142e - (chore): update with master - closes #2414 (closed)
• ca77f94f - (feat): working mvp of ssr
• 8dfc9b3a - (chore): performance bumps and browser specific delays
• 4399c6bc - (fix): failing spec tests
• 6a3dac72 - (fix): plotly fix, preparation for full server bundle and xsrf token re-introduced
• 14ab8c6e - (chore): ci configs
• 46f380ca - (fix): do not cache mobile incorrectly
• cfe0cb4a - (chore): some minor fixes for mobile improvements
• 361ef20c - (fix): do not show permissions if logged out
• 7cb62c62 - (chore): introduce build optimizer
• e9eee3a7 - (chore): preload material icons to improve first paint
• cd9272cd - (feat): meta service for SEO
• 2a206794 - (refactor): SEO from backend to frontend
• 09374b66 - (refactor): remove all uses of window.Minds
• c53c0aaa - (refactor): storage to cookies where applicable
• 4fda5f24 - (chore): allow for epic branches to push docker containers to aws
• 17b9abb5 - (fix): do not return null for nsfw reasons
• 7652c43d - (fix): remind asset links
• ff284a94 - (chore): do not stretch checkboxes
• 8d424529 - (fix): css should be loaded with correct asset path
• befad6c1 - (chore): remove icon preload
• eaf8a773 - (chore): cookie notice for all
• fc1185d7 - (chore): reduce plotly bundle
• af02de4b - (fix): nsfw cookie fix and notices.json credential error
• 3c5dae2d - (fix): wallet not loading when loaded server side
• 2118f305 - (fix): groups not loading server side
• b5b38399 - (fix): do not applu 100% width to checkboxes on homepage
• 26795138 - (fix): bad url for avatars
• b73ee1b0 - (chore): fix seo for blogs
• 98fd4fbe - (chore): temporary favicons
• eeb4b9e1 - (fix): groups create page not loading
• 9c600c2c - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
• 1363cae7 - (fix): canary assets path
• 96c066b0 - (fix): sockets issue
• 03a80ca3 - (fix): wrong path for canary bg
• a0ab3d48 - (fix): try not to render css for checkboxes
• b876854f - (fix): only show more groups if we have groups
• c3b33785 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
• 5a27ec5f - (feat): checkboxes on homepage
• a4d3e5e9 - (chore): update local build and serve scripts
• 95c2bfe7 - (fix): pro sites should wait for configs to be resolved
• 3a90b3dc - (fix): date dropdown should be in common posdt master merge
• adb6015c - (fix): reset router if pro
• f15627e1 - (fix): pro fixes
• 176a3c8f - (chore): move sentry to diagnostics service
• fc6a8b2e - (chore): sentry capture exception for pro
• 386ca4f8 - (fix): only render css bindings if in browser
• 2b3b74b3 - (chore): add Object type top platformId
• 75639885 - (fix): wrap session storage in try catch
• 7c5d306b - (fix): og tags incorrect
• da3ed520 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
• 5fede3a6 - Merge branch 'master' of https://gitlab.com/Minds/front into epic/SSR
• 145a730f - (chore): some small ci changes to test production pipeline works with SSR
• 225dc6f3 - (chore): allow for master to hit preprod
• ff63f69d - Merge branch 'fix/modal-pager-sync' into 'production'
• fae30718 - Search period defaults and sort bar tweaks
• 410e752c - Merge branch 'chore/default-search-period' into 'master'
• 2261e73f - (chore): remove review dependency
• 5ffd58f5 - Merge branch 'production' of https://gitlab.com/Minds/front
• 44667f0d - (chore): bring sandbox helm chart branch to master
• fd261feb - (fix): remind preview cdn url - fixes #2531 (closed)
• 6fc73b99 - New Channel Registration, Signup button remains disabled
• 759cb8aa - Merge branch 'fix/register-issue-2527' into 'master'
• 9c924ddb - (feat): implements captcha - #646 (closed)
• a8ed91a5 - Merge branch 'feat/646-captcha' into 'master'
• edbca40b - (fix): #2535 (closed) pass route params to server
• 6968119e - Merge branch 'fix/2535-pass-through-queryparams' into 'master'
• 443efc60 - (fix): couple issues when configs fails to load
• c6310433 - (chore): add ssr to canary page
• bd6a5972 - Merge branch 'master' of gitlab.com:minds/front into fix/sockets-rxjs-handling-errors-2489

Compare with previous version

changed target branch from production to master

approved this merge request

merged

mentioned in commit 8c856a55