Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 382
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !726

Merged
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Ability to go to original channel page from a published pro site

  • Overview 6
  • Commits 7
  • Pipelines 6
  • Changes 4
3/3 threads resolved

closes engine#1212 (closed)

Testing: Emi's pro site:

https://feat-link-to-channel-from-pro-site.minds.io/pro/0xemi

In the footer you should see the minds logo, which should redirect to the normal channel upon clicking on it:

image

Edited 1 week ago by Brian Hatchet
Request to merge feat/link-to-channel-from-pro-site into master
Pipeline #115637441 passed with warnings for 5e66e204 on feat/link-to-channel-from-pro-site
              Merge request approved. Approved by
              Mark Harding
              Ben Hayward Juan Manuel Solaro Brian Hatchet Emiliano Balbuena Xander Miller

              Merged by Mark Harding 17 minutes ago

              The changes were merged into master with cf8a0350

              The source branch has been deleted

              Closed engine#1212 (closed)

              Pipeline #115693304 running for cf8a0350 on master
                              • Marcelo Rivera @eiennohi added Priority::1 - High Sprint::01/15 - Youthful Yabby Squad::Blue scoped labels 3 weeks ago

                                added scoped labels

                              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                                added 1 commit

                                • 89f83bbc - (fix): move image next to social profiles and decolorize it

                                Compare with previous version

                              • Marcelo Rivera @eiennohi added Status::BuddyReview scoped label 3 weeks ago

                                added scoped label

                              • Mark Harding
                                Mark Harding @markeharding · 1 week ago
                                Owner

                                1 week :eyes:

                                Testing instructions?

                              • Mark Harding
                                Mark Harding @markeharding · 1 week ago
                                Owner

                                @eiennohi please update with testing instructions and don't let your MR's go stale.

                              • Marcelo Rivera @eiennohi changed the description 1 week ago

                                changed the description

                              • Marcelo Rivera @eiennohi added 46 commits 1 week ago

                                added 46 commits

                                • 89f83bbc...2cb1c987 - 45 commits from branch master
                                • 345c5d30 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site

                                Compare with previous version

                              • Olivia Madrid @omadrid approved this merge request 1 week ago

                                approved this merge request

                              • Mark Harding
                                Mark Harding @markeharding · 1 week ago
                                Owner

                                @eiennohi please provide clear steps to test this. Links?

                              • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 week ago

                                changed the description

                                • Brian Hatchet
                                  Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                                  Developer
                                  Resolved by Marcelo Rivera 1 week ago

                                  Works just fine but it's pretty much invisible on Emi's review pro site

                                  Needs some alt text to say "Minds"

                                  The meatball menu is below the light bulb and looks like it dangles.

                                • Please register or sign in to reply
                                • Brian Hatchet
                                  Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                                  Developer
                                  Resolved by Marcelo Rivera 1 week ago

                                  Needs to point to production

                                • Please register or sign in to reply
                              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                                added 1 commit

                                • 3a1f6231 - (feat):added alt attribute to logo

                                Compare with previous version

                              • Marcelo Rivera @eiennohi changed target branch from master to production 1 week ago

                                changed target branch from master to production

                              • Marcelo Rivera @eiennohi resolved all threads 1 week ago

                                resolved all threads

                              • Marcelo Rivera @eiennohi changed target branch from production to master 2 days ago

                                changed target branch from production to master

                              • Marcelo Rivera @eiennohi added 70 commits 2 days ago

                                added 70 commits

                                • 3a1f6231...759cb8aa - 69 commits from branch master
                                • e5ffbe11 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site

                                Compare with previous version

                              • Mark Harding
                                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                                Resolved by Marcelo Rivera 4 hours ago
                              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 2 days ago

                                added scoped label and automatically removed label

                              • Marcelo Rivera @eiennohi added 9 commits 4 hours ago

                                added 9 commits

                                • e5ffbe11...43727865 - 7 commits from branch master
                                • 33efb0e3 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site
                                • 5e66e204 - (fix): remove query param

                                Compare with previous version

                              • Marcelo Rivera @eiennohi resolved all threads 4 hours ago

                                resolved all threads

                              • Marcelo Rivera @eiennohi added Status::BuddyReview scoped label and automatically removed Status::Requires Changes label 4 hours ago

                                added scoped label and automatically removed label

                              • Mark Harding @markeharding approved this merge request 17 minutes ago

                                approved this merge request

                              • Mark Harding @markeharding merged 17 minutes ago

                                merged

                              • Mark Harding @markeharding mentioned in commit cf8a0350 17 minutes ago

                                mentioned in commit cf8a0350

                              Please register or sign in to reply
                              0 Assignees
                              None
                              None
                              Milestone
                              None
                              Time tracking
                              No estimate or time spent
                              4
                              Labels
                              Priority::1 - High Sprint::01/15 - Youthful Yabby Squad::Blue Status::BuddyReview
                              Lock merge request
                              Unlocked
                              10
                              10 participants
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              user avatar
                              Reference: minds/front!726