Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 383
  • Merge Requests 66
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !768

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
Report abuse

Group explicit overlay #2402

  • Overview 1
  • Commits 10
  • Pipelines 4
  • Changes 5
0/1 thread resolved

Summary

Closes #2402

Added in overlay for mature groups.

Steps to test

  1. Make a new user (User A)
  2. With User A, make 2 groups. Call one nsfw and one non-nsfw.
  3. Log out, and in as the Minds admin account.
  4. Mark the nsfw group as NSFW using the dropdown (remember to refresh if you don't see the option).
  5. Refresh, it should show the overlay. - note down the URL
  6. Go to User A's channel, mark it as NSFW for Pornography / Nudity - note down the channel URL.
  7. Refresh the channel, you should see the explicit overlay.
  8. Switch it back, and refresh; you should not see the explicit overlay.
  9. Turn it back on and log out
  10. Check the channel, it should show overlay and should say that it is a channel.
  11. Check the group, it should also show overlay and should say that it is a group.

Estimated Regression Scope

This change affects the mature overlay in groups and on channels. In the worst circumstance, it could error out and cause issues showing the channel or group. It's also possible it could error out more subtly and show at inappropriate times (of-course I've definitely aimed for this NOT to happen).

Edited 19 minutes ago by Ben Hayward
Request to merge feat/group-mature-filter-2402 into master
The source branch is 5 commits behind the target branch
Open in Web IDE
Pipeline #115656089 running for 7c81e856 on feat/group-mature-filter-2402
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding Juan Manuel Solaro Brian Hatchet Emiliano Balbuena Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Deletes source branch

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on an old version of the diff 1 hour ago
                Last updated by Ben Hayward 35 minutes ago
                package.json
                12 12 "build-dev": "npm run build:dev",
                13 13 "serve-dev": "npm run server:ssr",
                14 14 "build:dev": "ng build --output-path dist --deploy-url=/ --watch=true --poll=800",
                15 "serve:dev": "ng serve --host=0.0.0.0 --deploy-url=/ --configuration=hmr --hmr --poll=800 --progress --disableHostCheck=true",
                15 "preserve:dev": "npm run prebuild-dev -- --deploy-url=http://${HOST:-localhost}:${PORT:-4200}",
                • Ben Hayward
                  Ben Hayward @benhayward.ben · 1 hour ago
                  Developer

                  Needs reverting

                • Ben Hayward @benhayward.ben changed this line in version 2 of the diff 35 minutes ago

                  changed this line in version 2 of the diff

                • Please register or sign in to reply
              • Ben Hayward @benhayward.ben added 2 commits 35 minutes ago

                added 2 commits

                • 6aa592e8 - Reverting package.json
                • 2c98c6a6 - Fixed spec tests

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 32 minutes ago

                added 1 commit

                • e45fe9d0 - Unneeded additon

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 19 minutes ago

                changed the description

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Awaiting Review scoped labels 19 minutes ago

                added scoped labels

              • Ben Hayward @benhayward.ben added 1 commit 18 minutes ago

                added 1 commit

                • 7c81e856 - Missed a file

                Compare with previous version

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!768