Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 384
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !726

Open
Opened 2 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Ability to go to original channel page from a published pro site

  • Overview 6
  • Commits 5
  • Pipelines 5
  • Changes 4
2/3 threads resolved

closes engine#1212

Testing: Emi's pro site:

https://feat-link-to-channel-from-pro-site.minds.io/pro/0xemi

In the footer you should see the minds logo, which should redirect to the normal channel upon clicking on it:

image

Edited 6 days ago by Brian Hatchet
Request to merge feat/link-to-channel-from-pro-site into master
Open in Web IDE
Pipeline #114895706 failed for e5ffbe11 on feat/link-to-channel-from-pro-site
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena Martin Santangelo Rami Albatal Mark Harding Brian Hatchet
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes engine#1212

              Deletes source branch

              • Marcelo Rivera @eiennohi added Priority::1 - High Sprint::01/15 - Youthful Yabby Squad::Blue scoped labels 2 weeks ago

                added scoped labels

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 89f83bbc - (fix): move image next to social profiles and decolorize it

                Compare with previous version

              • Marcelo Rivera @eiennohi added Status::BuddyReview scoped label 2 weeks ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding · 1 week ago
                Owner

                1 week :eyes:

                Testing instructions?

              • Mark Harding
                Mark Harding @markeharding · 6 days ago
                Owner

                @eiennohi please update with testing instructions and don't let your MR's go stale.

              • Marcelo Rivera @eiennohi changed the description 6 days ago

                changed the description

              • Marcelo Rivera @eiennohi added 46 commits 6 days ago

                added 46 commits

                • 89f83bbc...2cb1c987 - 45 commits from branch master
                • 345c5d30 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site

                Compare with previous version

              • Olivia Madrid @omadrid approved this merge request 6 days ago

                approved this merge request

              • Mark Harding
                Mark Harding @markeharding · 6 days ago
                Owner

                @eiennohi please provide clear steps to test this. Links?

              • Brian Hatchet :speech_balloon: @brianhatchet changed the description 6 days ago

                changed the description

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 6 days ago
                  Developer
                  Resolved by Marcelo Rivera 5 days ago

                  Works just fine but it's pretty much invisible on Emi's review pro site

                  Needs some alt text to say "Minds"

                  The meatball menu is below the light bulb and looks like it dangles.

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 6 days ago
                  Developer
                  Resolved by Marcelo Rivera 5 days ago

                  Needs to point to production

                • Please register or sign in to reply
              • Marcelo Rivera @eiennohi added 1 commit 5 days ago

                added 1 commit

                • 3a1f6231 - (feat):added alt attribute to logo

                Compare with previous version

              • Marcelo Rivera @eiennohi changed target branch from master to production 5 days ago

                changed target branch from master to production

              • Marcelo Rivera @eiennohi resolved all threads 5 days ago

                resolved all threads

              • Marcelo Rivera @eiennohi changed target branch from production to master 1 hour ago

                changed target branch from production to master

              • Marcelo Rivera @eiennohi added 70 commits 1 hour ago

                added 70 commits

                • 3a1f6231...759cb8aa - 69 commits from branch master
                • e5ffbe11 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 8 minutes ago
                src/app/modules/channel-container/channel-container.component.ts
                53 55
                54 56 if (
                55 57 this.username &&
                56 (!this.channel || this.channel.username != this.username)
                58 (!this.channel || this.channel.username !== this.username)
                57 59 ) {
                58 60 this.load();
                59 61 }
                60 62 }
                61 63 });
                64
                65 this.queryParam$ = this.route.queryParams.subscribe(params => {
                • Mark Harding
                  Mark Harding @markeharding · 8 minutes ago
                  Owner

                  Rouge subscription. Also $ is usually just for observables and not the subscriptions itself

                • Please register or sign in to reply
              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 8 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              4
              Labels
              Priority::1 - High Sprint::01/15 - Youthful Yabby Squad::Blue Status::Requires Changes
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!726