Ability to go to original channel page from a published pro site
closes engine#1212
Testing: Emi's pro site:
https://feat-link-to-channel-from-pro-site.minds.io/pro/0xemi
In the footer you should see the minds logo, which should redirect to the normal channel upon clicking on it:
added scoped labels
added 1 commit
- 89f83bbc - (fix): move image next to social profiles and decolorize it
added scoped label
- Owner
1 week
Testing instructions?
- Owner
@eiennohi please update with testing instructions and don't let your MR's go stale.
changed the description
added 46 commits
-
89f83bbc...2cb1c987 - 45 commits from branch
master
- 345c5d30 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site
-
89f83bbc...2cb1c987 - 45 commits from branch
approved this merge request
- Owner
@eiennohi please provide clear steps to test this. Links?
changed the description
- DeveloperResolved by Marcelo Rivera
Works just fine but it's pretty much invisible on Emi's review pro site
Needs some alt text to say "Minds"
The meatball menu is below the light bulb and looks like it dangles.
- DeveloperResolved by Marcelo Rivera
Needs to point to production
changed target branch from
master
toproduction
resolved all threads
changed target branch from
production
tomaster
added 70 commits
-
3a1f6231...759cb8aa - 69 commits from branch
master
- e5ffbe11 - Merge remote-tracking branch 'upstream/master' into feat/link-to-channel-from-pro-site
-
3a1f6231...759cb8aa - 69 commits from branch
53 55 54 56 if ( 55 57 this.username && 56 (!this.channel || this.channel.username != this.username) 58 (!this.channel || this.channel.username !== this.username) 57 59 ) { 58 60 this.load(); 59 61 } 60 62 } 61 63 }); 64 65 this.queryParam$ = this.route.queryParams.subscribe(params => { - Owner
Rouge subscription. Also
$
is usually just for observables and not the subscriptions itself
added scoped label and automatically removed label