Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 385
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !735

Open
Opened 1 week ago by Jim Toth@jim-toth:milky_way:1
Report abuse

WIP (feat): code sytnax highlighting

  • Overview 2
  • Commits 13
  • Pipelines 11
  • Changes 22

Work in Progress

Closes minds#864

Request to merge jim-toth:feat/code-syntax-highlighting-864 into master
The source branch is 87 commits behind the target branch
Open in Web IDE
Pipeline #114686651 failed for 1e5716b4 on jim-toth:feat/code-syntax-highlighting-864
              Requires 3 more approvals from Devs, Deployers, and QA.
              Olivia Madrid Marcelo Rivera Emiliano Balbuena Mark Harding Rami Albatal
              There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally

              Closes minds#864

              Deletes source branch

              You can merge this merge request manually using the
              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 9609e431 - undo whitespace change

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 2 commits 1 week ago

                added 2 commits

                • c317aa43 - Remove SyntaxHighlightModule
                • ba569550 - Merge branch 'feat/code-syntax-highlighting-864' of...

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 3b9cd258 - Moves code syntax pipe to pipes dir

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 7c14f922 - Adds code highlighting module, code highlighting pipe to posts and comments

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 1a8e63d3 - Remove code-highlight.directive

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 30623668 - re-add whitespace

                Compare with previous version

              • Jim Toth
                Jim Toth :milky_way: @jim-toth · 1 week ago

                Quick update on progress:

                • Code Highlight Module
                • Posts
                • Comments
                • Blog
                • Mobile

                This is entirely a front-end solution, code to be highlighted is never executed.

                Working with the Medium editor, I believe it would be best to add another plugin button for code highlighting. Any time a newline is entered into the editor it inserts </p><p> in between, which won't play well with code highlighting especially if the code being highlighted is HTML. I'll add a plugin to the Medium editor to highlight a code block by attempting to remove or prevent the </p><p> tags being inserted and wrap the block with <pre><code> as per Highlight.js convention.

                For Mobile, I'll create a code-highlight component in react.

              • Jim Toth :milky_way: @jim-toth added 2 commits 1 week ago

                added 2 commits

                • 2f346f70 - Adds package-lock.json for highlight.js
                • a1d6b23c - Merge branch 'feat/code-syntax-highlighting-864' of...

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 37180c95 - Remove failing blog test for now

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 1 week ago

                added 1 commit

                • 4489d090 - Fixes Activity component tests for code highlight

                Compare with previous version

              • Jim Toth :milky_way: @jim-toth added 1 commit 30 minutes ago

                added 1 commit

                • 1e5716b4 - Adds code highlight plugin for medium-editor

                Compare with previous version

              • Jim Toth
                Jim Toth :milky_way: @jim-toth · 27 minutes ago

                Progress Update:

                • Code Highlight Module
                • Posts
                • Comments
                • Blog
                  • Medium Editor Plugin
                    • Functionality
                    • Style
                • Mobile
                  • Posts
                  • Comments
                  • Blog
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Lock merge request
              Unlocked
              12
              12 participants
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              user avatar
              Reference: minds/front!735