Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 262
  • Merge Requests 26
  • CI / CD
  • Security & Compliance
  • Packages
  • Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !435

Merged
Opened 2 weeks ago by Emiliano Balbuena@edgebal
Report abuse

Feature flags from GitLab

  • Overview 15
  • Commits 18
  • Pipelines 13
  • Changes 34
7/7 threads resolved

Summary

Integrate GitLab onto feature flags management

  • Closes #966 (closed).
  • Closes #1298 (closed).

Steps to test

  • Go to https://gitlab.com/minds/engine/-/feature_flags
  • Click the pencil icon on the media-modal row.
  • Notice the [review-site] environment state (flipped on=true, off=false)
  • Open https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
  • Navigate to features > media-modal. Check the value matches what you saw on GitLab.
  • Now switch it.
  • Wait 5 minutes or more (there's a small cache)
  • Reload https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
  • Navigate to features > media-modal. Check the value reflects your switch on GitLab.

Note: Ensure you sync with other testers because you might be flipping each other switches.

Estimated Regression Scope

Feature flags might not be correctly read or exported to frontend.

Deployment

New Settings

$CONFIG->set('unleash', [
    'apiUrl' => '', // URL to GitLab's Unleash server
    'instanceId' => '', // GitLab's Unleash instance ID
    'applicationName' => '', // GitLab Feature Flags environment
    'pollingIntervalSeconds' => 300, // Cache bust
    'metricsIntervalSeconds' => 15, // Metrics interval
]);
Edited 2 days ago by Emiliano Balbuena
Request to merge epic/feature-flags into master
Pipeline #112679777 passed for 32785149 on epic/feature-flags
          Merge request approved. Approved by
          Brian Hatchet Mark Harding
          Martin Santangelo Rami Albatal Ben Hayward Olivia Madrid Marcelo Rivera

          Merged by Mark Harding 8 minutes ago

          The changes were merged into master with 3514903b

          The source branch has been deleted

          Closed #1298 (closed) and #966 (closed)

          Pipeline #112685459 waiting for manual action for 3514903b on master
                        • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 2 weeks ago

                          added scoped label

                        • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                          changed the description

                        • Emiliano Balbuena @edgebal mentioned in issue #966 (closed) 2 weeks ago

                          mentioned in issue #966 (closed)

                        • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                          changed the description

                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
                          Resolved by Emiliano Balbuena 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
                          Resolved by Emiliano Balbuena 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
                          Resolved by Emiliano Balbuena 1 week ago
                        • Emiliano Balbuena @edgebal added 13 commits 1 week ago

                          added 13 commits

                          • 104a2e41...570a6e81 - 12 commits from branch master
                          • ea0a7219 - Merge remote-tracking branch 'origin/master' into epic/feature-flags

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                          added 1 commit

                          • c04e224b - (refactor): Introduce context groups; features service layer

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                          added 1 commit

                          • abcf3497 - (fix): Use session; (test): Fix all tests

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                          added 1 commit

                          • fc847e39 - (chore): VCS for minds/unleash-client-php

                          Compare with previous version

                        • Emiliano Balbuena @edgebal resolved all threads 1 week ago

                          resolved all threads

                        • Emiliano Balbuena @edgebal added 3 commits 5 days ago

                          added 3 commits

                          • fc847e39...31877e67 - 2 commits from branch master
                          • c5ad49f0 - Merge remote-tracking branch 'origin/master' into epic/feature-flags

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 5 days ago

                          added 1 commit

                          • 535b0b41 - (chore): Use unleash-client-php 0.1.1

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 5 days ago

                          added 1 commit

                          • 95129e19 - (feat): Whitelist feature keys

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 5 commits 5 days ago

                          added 5 commits

                          • efd07fe7 - (chore): Remove test features
                          • 6a29c603 - (feat): Resolve user groups for $CONFIG values
                          • 30e7c4be - (chore): Whitelisting should happen in services
                          • 2b27c128 - (feat): Environment variables service
                          • 890731ee - (chore): PHPdoc

                          Compare with previous version

                          Toggle commit list
                        • Emiliano Balbuena @edgebal changed the description 5 days ago

                          changed the description

                        • Emiliano Balbuena @edgebal added 1 commit 4 days ago

                          added 1 commit

                          • ac1cb6df - (test): Spec test and tweaks on tested classes

                          Compare with previous version

                        • Emiliano Balbuena @edgebal unmarked as a Work In Progress 3 days ago

                          unmarked as a Work In Progress

                        • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 3 days ago

                          added scoped label

                        • Emiliano Balbuena @edgebal changed the description 2 days ago

                          changed the description

                        • Ben Hayward
                          Ben Hayward @benhayward.ben started a thread on the diff 2 days ago
                          Resolved by Emiliano Balbuena 2 days ago
                        • Ben Hayward
                          Ben Hayward @benhayward.ben started a thread on the diff 2 days ago
                          Resolved by Emiliano Balbuena 2 days ago
                        • Emiliano Balbuena @edgebal resolved all threads 2 days ago

                          resolved all threads

                        • Ben Hayward
                          Ben Hayward @benhayward.ben · 2 days ago
                          Developer

                          Note: Ensure you sync with other testers because you might be flipping each other switches.

                          Testing

                        • Ben Hayward @benhayward.ben approved this merge request 2 days ago

                          approved this merge request

                        • Ben Hayward
                          Ben Hayward @benhayward.ben · 2 days ago
                          Developer

                          Approved, working fine

                        • Ben Hayward @benhayward.ben unassigned @edgebal 2 days ago

                          unassigned @edgebal

                        • Ben Hayward @benhayward.ben assigned to @edgebal, @brianhatchet, @markeharding, and @xander-miller 2 days ago

                          assigned to @edgebal, @brianhatchet, @markeharding, and @xander-miller

                          • Mark Harding
                            Mark Harding @markeharding · 7 hours ago
                            Owner
                            Resolved by Emiliano Balbuena 24 minutes ago

                            I'm unable to make the feature flag false. Let's discuss on a call. Can we also confirm all flags are false by default?

                          • Emiliano Balbuena
                            Last reply by Emiliano Balbuena 4 hours ago
                        • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 7 hours ago

                          added scoped label and automatically removed label

                        • Emiliano Balbuena @edgebal added 8 commits 4 hours ago

                          added 8 commits

                          • ac1cb6df...785576b4 - 6 commits from branch master
                          • c690c251 - (chore): Use env vars for Unleash config
                          • fa210f05 - Merge remote-tracking branch 'origin/master' into epic/feature-flags

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added Status::Review scoped label and automatically removed Status::Requires Changes label 4 hours ago

                          added scoped label and automatically removed label

                        • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Review label 4 hours ago

                          added scoped label and automatically removed label

                        • Brian Hatchet
                          Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 3 hours ago
                          Resolved by Emiliano Balbuena 24 minutes ago
                        • Mark Harding @markeharding approved this merge request 3 hours ago

                          approved this merge request

                        • Emiliano Balbuena @edgebal added 1 commit 40 minutes ago

                          added 1 commit

                          • 788646f5 - (fix): Sentry Monolog handler should have minLevel set

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 31 minutes ago

                          added 1 commit

                          • 32785149 - (chore): Default to WARNING, do not send below WARNING to Monolog

                          Compare with previous version

                        • Mark Harding @markeharding approved this merge request 26 minutes ago

                          approved this merge request

                        • Emiliano Balbuena @edgebal resolved all threads 24 minutes ago

                          resolved all threads

                        • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 23 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding mentioned in commit 3514903b 8 minutes ago

                          mentioned in commit 3514903b

                        • Mark Harding @markeharding merged 8 minutes ago

                          merged

                        Please register or sign in to reply
                        4 Assignees
                        Mark Harding's avatar
                        Emiliano Balbuena's avatar
                        Brian Hatchet's avatar
                        Xander Miller's avatar
                        None
                        Milestone
                        None
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        Squad::Yellow Status::Awaiting Review
                        Lock merge request
                        Unlocked
                        9
                        9 participants
                        user avatar
                        user avatar
                        user avatar
                        user avatar
                        user avatar
                        user avatar
                        user avatar
                        Reference: minds/engine!435