Feature flags from GitLab
Summary
Integrate GitLab onto feature flags management
- Closes #966 (closed).
- Closes #1298 (closed).
Steps to test
- Go to https://gitlab.com/minds/engine/-/feature_flags
- Click the pencil icon on the
media-modal
row. - Notice the
[review-site]
environment state (flipped on=true, off=false) - Open https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
- Navigate to
features > media-modal
. Check the value matches what you saw on GitLab. - Now switch it.
- Wait 5 minutes or more (there's a small cache)
- Reload https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
- Navigate to
features > media-modal
. Check the value reflects your switch on GitLab.
Note: Ensure you sync with other testers because you might be flipping each other switches.
Estimated Regression Scope
Feature flags might not be correctly read or exported to frontend.
Deployment
New Settings
$CONFIG->set('unleash', [
'apiUrl' => '', // URL to GitLab's Unleash server
'instanceId' => '', // GitLab's Unleash instance ID
'applicationName' => '', // GitLab Feature Flags environment
'pollingIntervalSeconds' => 300, // Cache bust
'metricsIntervalSeconds' => 15, // Metrics interval
]);
added scoped label
changed the description
mentioned in issue #966 (closed)
changed the description
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
added 13 commits
-
104a2e41...570a6e81 - 12 commits from branch
master
- ea0a7219 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
104a2e41...570a6e81 - 12 commits from branch
added 1 commit
- c04e224b - (refactor): Introduce context groups; features service layer
resolved all threads
added 3 commits
-
fc847e39...31877e67 - 2 commits from branch
master
- c5ad49f0 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
fc847e39...31877e67 - 2 commits from branch
changed the description
added 1 commit
- ac1cb6df - (test): Spec test and tweaks on tested classes
unmarked as a Work In Progress
added scoped label
changed the description
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
resolved all threads
- Developer
Note: Ensure you sync with other testers because you might be flipping each other switches.
Testing
approved this merge request
- Developer
Approved, working fine
unassigned @edgebal
assigned to @edgebal, @brianhatchet, @markeharding, and @xander-miller
- OwnerResolved by Emiliano Balbuena
I'm unable to make the feature flag false. Let's discuss on a call. Can we also confirm all flags are false by default?
- Last reply by Emiliano Balbuena
added scoped label and automatically removed label
added 8 commits
-
ac1cb6df...785576b4 - 6 commits from branch
master
- c690c251 - (chore): Use env vars for Unleash config
- fa210f05 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
ac1cb6df...785576b4 - 6 commits from branch
added scoped label and automatically removed label
added scoped label and automatically removed label
- Resolved by Emiliano Balbuena
approved this merge request
added 1 commit
- 788646f5 - (fix): Sentry Monolog handler should have minLevel set
added 1 commit
- 32785149 - (chore): Default to WARNING, do not send below WARNING to Monolog
approved this merge request
resolved all threads
approved this merge request
mentioned in commit 3514903b
merged