Summary

Allow faster pagination when going back and forth on media modal

• Closes #2419

Steps to test

• Go to a channel with media content
• Click on a image or a video
• There should be a really small delay for the arrows to appear.
• Try navigating back and forth, there should be no delay for the arrows to pop-in.
• When navigating, check the dates to see if you're going back and forth.
• Go to a group (such as: https://goal-modal-pager-cache.minds.io/groups/profile/1051617384458096641/feed)
• Upload an image with your user
• Navigate through it, other images in that group (uploaded by another users) should appear

Known issues

There's an engine issue, which affects the entity displayed on the modal. engine#1326

Estimated Regression Scope

Regressions might arise when loading the media modal or navigating on it.

added scoped label

added 1 commit

• b4dab04a - (fix): Wrong calculation of pool index value

Compare with previous version

added 2 commits

• 2a72ba71 - (chore): Remove console.debug, JSdoc and separate fetch concerns
• c52417ca - (refactor): Use BehaviorSubject for modal pager entities

Compare with previous version

added 8 commits

• c52417ca...aef1b6f6 - 6 commits from branch master
• f21f1bc2 - (chore): Better loading handling
• c251816b - Merge remote-tracking branch 'origin/master' into goal/modal-pager-cache

Compare with previous version

unmarked as a Work In Progress

changed the description

added scoped label

changed the description

One thing I noted, if I open a reminded media post in a modal, it has no arrows, is this a design choice?

It also throws this in console. I cannot tell if this is due to this MR or is an environmental issue.

Not directly related to this MR but the new system as a whole.

Are we handling NSFW correctly here? I don't think we should be showing NSFW images unless the user has enabled mature, or without an overlay.

E.g. if I make 2 posts, one NSFW, and one SFW. If I click the SFW image and go right, it will show an uncensored mature image.

Basically you're going back and forth the user's/group's gallery (as if you go to their feeds and filter by video/image/blog). We can make the media modal NSFW aware, but that will require further modifications that are out of the scope of this MR.

cc/ @brianhatchet

We have a card created for this. Good catch, @benhayward.ben

resolved all threads

changed the description

added scoped label and automatically removed label

approved this merge request