Feature flags from GitLab
Summary
Integrate GitLab onto feature flags management
Steps to test
- Go to https://gitlab.com/minds/engine/-/feature_flags
- Click the pencil icon on the
media-modalrow. - Notice the
[review-site]environment state (flipped on=true, off=false) - Open https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
- Navigate to
features > media-modal. Check the value matches what you saw on GitLab. - Now switch it.
- Wait 5 minutes or more (there's a small cache)
- Reload https://epic-feature-flags.minds.io/api/v1/minds/config in Postman (or Firefox)
- Navigate to
features > media-modal. Check the value reflects your switch on GitLab.
Note: Ensure you sync with other testers because you might be flipping each other switches.
Estimated Regression Scope
Feature flags might not be correctly read or exported to frontend.
Deployment
New Settings
$CONFIG->set('unleash', [
'apiUrl' => '', // URL to GitLab's Unleash server
'instanceId' => '', // GitLab's Unleash instance ID
'applicationName' => '', // GitLab Feature Flags environment
'pollingIntervalSeconds' => 300, // Cache bust
'metricsIntervalSeconds' => 15, // Metrics interval
]);
added scoped label
changed the description
changed the description
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Resolved by Emiliano Balbuena- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
added 13 commits
-
104a2e41...570a6e81 - 12 commits from branch
master - ea0a7219 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
104a2e41...570a6e81 - 12 commits from branch
added 1 commit
- c04e224b - (refactor): Introduce context groups; features service layer
resolved all threads
added 3 commits
-
fc847e39...31877e67 - 2 commits from branch
master - c5ad49f0 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
fc847e39...31877e67 - 2 commits from branch
changed the description
added 1 commit
- ac1cb6df - (test): Spec test and tweaks on tested classes
unmarked as a Work In Progress
added scoped label
changed the description
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
resolved all threads
- Developer
Note: Ensure you sync with other testers because you might be flipping each other switches.
Testing
approved this merge request
- Developer
Approved, working fine
unassigned @edgebal
assigned to @edgebal, @brianhatchet, @markeharding, and @xander-miller
- Owner
I'm unable to make the feature flag false. Let's discuss on a call. Can we also confirm all flags are false by default?
![Emiliano Balbuena](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperAlready discussed in-call with Mark:
- Review sites heavy caching on front/index
- Unleash should prefer environment variables for URL, Instance ID and Application Name (environment) settings
- Application Name should be the same variable used by sentry (MINDS_ENV)
- Will test on a subdomain
cc/ @brianhatchet
added scoped label and automatically removed label
added 8 commits
-
ac1cb6df...785576b4 - 6 commits from branch
master - c690c251 - (chore): Use env vars for Unleash config
- fa210f05 - Merge remote-tracking branch 'origin/master' into epic/feature-flags
-
ac1cb6df...785576b4 - 6 commits from branch
added scoped label and automatically removed label
added scoped label and automatically removed label
1 <?php 2 /** 3 * FeatureNotImplementedException 4 * 5 * @author edgebal 6 */ 7 8 namespace Minds\Core\Features\Exceptions; 9 10 use Exception; - Developer
approved this merge request
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}