Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 354
  • Merge Requests 55
  • CI / CD
  • Security & Compliance
  • Packages
  • Project Analytics
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !394

Open
Opened 6 months ago by Marcelo Rivera@eiennohi
Report abuse

[Sprint/HipsterHedgehog] (feat): ability to copy and paste images into posts and comments

  • Overview 16
  • Commits 14
  • Pipelines 9
  • Changes 11
2/3 threads resolved

closes minds#553

closes #2312

Edited 1 month ago by Marcelo Rivera
Request to merge feat/copy-and-paste-images-in-posts into master
The source branch is 37 commits behind the target branch
Open in Web IDE
Pipeline #109521087 passed with warnings for 62177ec5 on feat/copy-and-paste-images-in-posts
              Requires approval from Deployers. Approved by
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Martin Santangelo
              Martin Santangelo
              Emiliano Balbuena
              Emiliano Balbuena
              Rami Albatal
              Rami Albatal
              Ben Hayward
              Ben Hayward
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2312 and minds#553

              Deletes source branch

              • Marcelo Rivera @eiennohi mentioned in merge request !374 (closed) 6 months ago

                mentioned in merge request !374 (closed)

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 6 months ago
                Resolved by Marcelo Rivera 6 months ago
              • Mark Harding @markeharding added MR::Awaiting Review scoped label 6 months ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding · 6 months ago
                Owner

                Confirmed this works. However, my copied gif no longer animates with copy/paste flow?

              • Mark Harding
                Mark Harding @markeharding · 6 months ago
                Owner

                Also confirm !394 (diffs, comment 187720495) and then we are good

              • Marcelo Rivera @eiennohi added 28 commits 6 months ago

                added 28 commits

                • 18d4f68c...82595d15 - 26 commits from branch master
                • f21330be - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts
                • c71558d1 - (fix): brought back e.preventDefault();

                Compare with previous version

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 6 months ago
                Developer

                @markeharding, I did some research and found out that copying and pasting gifs only captures the current frame. It works like that everywhere, I think

              • Marcelo Rivera @eiennohi resolved all discussions 6 months ago

                resolved all discussions

              • Mark Harding @markeharding added Squad::Yellow scoped label 6 months ago

                added scoped label

              • Marcelo Rivera @eiennohi mentioned in issue #2312 1 month ago

                mentioned in issue #2312

              • Marcelo Rivera @eiennohi changed the description 1 month ago

                changed the description

              • Marcelo Rivera @eiennohi added 539 commits 1 month ago

                added 539 commits

                • c71558d1...80e43c8c - 538 commits from branch master
                • 52206363 - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                added 1 commit

                • 7d7b9624 - (fix): lint

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @edgebal and @xander-miller 1 month ago

                assigned to @edgebal and @xander-miller

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
                Developer

                Copy and paste into a post. Bam, it works great

              • Xander Miller
                Xander Miller @xander-miller · 1 month ago
                Developer

                Working for me too.

              • Xander Miller @xander-miller approved this merge request 1 month ago

                approved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 1 month ago

                approved this merge request

              • Emiliano Balbuena @edgebal unapproved this merge request 1 month ago

                unapproved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 1 month ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 1 month ago
                Developer

                Works for me too. I couldn't delete the attachment, but it's an upstream issue.

              • Xander Miller
                Xander Miller @xander-miller · 1 month ago
                Developer

                Several failures on the e2e tests. I think these are getting fixed on other in coming merge requests though.

                image

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
                Developer

                I currently don't have permissions to merge this into master. Assigning it to @markeharding

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
                Resolved by Marcelo Rivera 1 month ago
              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @eiennohi 1 month ago

                assigned to @eiennohi

              • Brian Hatchet :speech_balloon: @brianhatchet unassigned @edgebal and @xander-miller 1 month ago

                unassigned @edgebal and @xander-miller

              • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 1 month ago

                added 1 deleted label

              • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                added 1 commit

                • c0eeae28 - (fix): remove aliases and use correct naming for outputs

                Compare with previous version

              • Marcelo Rivera @eiennohi resolved all threads 1 month ago

                resolved all threads

              • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 month ago

                added scoped label and automatically removed label

              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 1 month ago
                Owner

                Comments work for me but the newsfeed does not.

              • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                added 1 commit

                • e0dbd1c2 - (fix): use filePaste vs OnFilePaste

                Compare with previous version

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 1 month ago
                Developer

                @markeharding just solved. Sorry about this, I had a local issue and missed the error. Just tested and it works fine now.

              • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 month ago

                added scoped label and automatically removed label

                • Mark Harding
                  Mark Harding @markeharding · 1 month ago
                  Owner

                  Error when trying to remove the image. This doesn't happen on production.

                  vendor.779a60b3ce201322a755.js:1 TypeError: Cannot read property 'unsubscribe' of undefined
                      at l.abort (main.4e9e29ab7caee12f5899.js:1)
                      at l.removeAttachment (main.4e9e29ab7caee12f5899.js:1)
                      at Object.handleEvent (main.4e9e29ab7caee12f5899.js:1)
                      at Object.handleEvent (vendor.779a60b3ce201322a755.js:1)
                      at Object.handleEvent (vendor.779a60b3ce201322a755.js:1)
                      at Fl (vendor.779a60b3ce201322a755.js:1)
                      at vendor.779a60b3ce201322a755.js:1
                      at HTMLDivElement.<anonymous> (vendor.779a60b3ce201322a755.js:1)
                      at HTMLDivElement.r (vendor.779a60b3ce201322a755.js:1)
                      at e.invokeTask (polyfills.055b24b90bf66d29b201.js:1)
                      at Object.onInvokeTask (vendor.779a60b3ce201322a755.js:1)
                      at e.invokeTask (polyfills.055b24b90bf66d29b201.js:1)
                      at t.runTask (polyfills.055b24b90bf66d29b201.js:1)
                      at t.invokeTask [as invoke] (polyfills.055b24b90bf66d29b201.js:1)
                      at _ (polyfills.055b24b90bf66d29b201.js:1)
                      at HTMLDivElement.m (polyfills.055b24b90bf66d29b201.js:1)
                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 49 minutes ago
                  Developer

                  Confirmed that I can delete a C/Ped image without error

                • Please register or sign in to reply
              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 1 month ago

                unapproved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label and removed 1 deleted label 1 month ago

                added 1 deleted label and removed 1 deleted label

              • Marcelo Rivera @eiennohi added 39 commits 1 month ago

                added 39 commits

                • e0dbd1c2...f3af959d - 37 commits from branch master
                • a4842dd6 - (fix): only cancel uploadSubscription if it has a value
                • c4f6f110 - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts

                Compare with previous version

              • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 month ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 28 commits 1 week ago

                added 28 commits

                • c4f6f110...b00415cc - 27 commits from branch master
                • 64521606 - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts

                Compare with previous version

              • Olivia Madrid @omadrid approved this merge request 1 week ago

                approved this merge request

              • Marcelo Rivera @eiennohi added 7 commits 1 week ago

                added 7 commits

                • 64521606...31db9b75 - 6 commits from branch master
                • 62177ec5 - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts

                Compare with previous version

              • Olivia Madrid @omadrid approved this merge request 2 days ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 49 minutes ago

                approved this merge request

              Please register or sign in to reply
              Assignee
              Marcelo Rivera's avatar
              Marcelo Rivera @eiennohi
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Martin Santangelo
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              user avatar
              Ben Hayward
              user avatar
              Xander Miller
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              Reference: minds/front!394