Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 347
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !689

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](fix): Fixed pro spec test. #2310

  • Overview 6
  • Commits 6
  • Pipelines 5
  • Changes 2
0/2 threads resolved

Closes #2310 Depends on helm-charts!25

To test, check the pipeline down below or checkout this branch locally and run Cypress.

Edited 2 hours ago by Ben Hayward
Request to merge fix/pro-marketting-2310 into master
Open in Web IDE
Pipeline #108982678 passed with warnings for a4c5a788 on fix/pro-marketting-2310
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Rami Albatal
              Rami Albatal
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2310

              Deletes source branch

              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 month ago

                added scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
                Developer

                @benhayward.ben can you explain your comment in the card?

                Pro tests are not supposed to run on sandboxes. I can, however, enable them if we can confirm sandbox & proudction are now running on prod / sandboxes

                We definitely need to get our e2e tests running on review sites for pro. What's the issue?

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 month ago
                Developer

                Sorry, may have typed too fast - They were initially skipped over because Pro sites were not working on the sandboxes, which they now are (I believe this was around the time the router changes were going in), so they need re-enabling and likely updating so they greenlight. Made a card for this here but I've left it in follow-up as it needs further breaking up. #2316

                This, however, is actually under the marketing banner so it is unrelated to that anyway, I hadn't realized at the time.

              • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                added 1 commit

                • 07abf688 - Added in location checking

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 month ago
                Developer

                Test failing here - I suspect we need to do something with helm to fix the environment so that it passes; we will discuss today.

              • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 16 commits 1 month ago

                added 16 commits

                • 07abf688...2cd5b807 - 15 commits from branch master
                • fb57f8ec - Merge branch 'master' of gitlab.com:minds/front into fix/pro-marketting-2310

                Compare with previous version

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 month ago
                  Developer

                  Pro marketing e2e tests are still failing

                • Please register or sign in to reply
              • Ben Hayward @benhayward.ben added 28 commits 1 week ago

                added 28 commits

                • fb57f8ec...52608901 - 27 commits from branch master
                • cc5c6f37 - Merge branch 'master' of gitlab.com:minds/front into fix/pro-marketting-2310

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 week ago
                Developer

                Updated to master / restarted sandboxes. If this does not work I'll try manually update with helm.

              • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::Requires Changes label 1 week ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 18 commits 6 hours ago

                added 18 commits

                • cc5c6f37...1181bc82 - 16 commits from branch master
                • b66dffe2 - Merge branch 'master' of gitlab.com:minds/front into fix/pro-marketting-2310
                • a4c5a788 - Added data attribute

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 2 hours ago

                changed the description

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on the diff 21 minutes ago
                cypress/integration/pro/marketing.spec.js
                11 11 cy.preserveCookies();
                12 12 });
                13 13
                14 const upgradeButton = 'm-pro--subscription .mf-button';
                14 const upgradeButton = '[data-cy=data-minds-pro-upgrade-button]';
                15 15 const wirePaymentsComponent = 'm-wire__paymentscreator .m-wire--creator';
                16 16
                17 17 it('should show a coming soon button', () => {
                • Emiliano Balbuena
                  Emiliano Balbuena @edgebal · 21 minutes ago
                  Developer

                  Outdated test case label

                • Please register or sign in to reply
              • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 21 minutes ago

                added scoped label and automatically removed label

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 21 minutes ago

                assigned to @benhayward.ben

              • Emiliano Balbuena @edgebal mentioned in issue #2310 20 minutes ago

                mentioned in issue #2310

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Martin Santangelo
              Reference: minds/front!689

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback