Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 347
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !716

Open
Opened 4 days ago by Emiliano Balbuena@edgebal
Report abuse

Modal pager

  • Overview 3
  • Commits 11
  • Pipelines 8
  • Changes 8
1/1 thread resolved

Summary

Go back and forth on images/videos/blogs for the current user or group on media modal.

Closes #1737.

Steps to test

  • Visit https://epic-modal-pager.minds.io/0xemi/. Arrows will appear in the main view to allow going back and forth all user's media.
  • Log in with your user
  • Post 2 or more images or blogs (video transcoder seems to be down for review sites)
  • Click one of them, you should be able to go back and forth using the arrows (keyboard/on-screen element)
  • Test that you are able to close the media modal using Esc key.
  • Test that when you use the keyboard arrows on text fields (i.e. the comment input) it doesn't trigger the navigation
  • Go to a group (or create a new one), copy the URL
  • Post a couple of images
  • Login with another user (or create a new one)
  • Go to the group and join it
  • Post a couple of images
  • Test that you can go back and forth all groups images on the media modal.

Estimated Regression Scope

  • Media modal entity loading
  • Media modal media sizing
  • Media modal permalink URLs
Edited 3 days ago by Emiliano Balbuena
Request to merge epic/modal-pager into master
Open in Web IDE
Pipeline #109011424 passed with warnings for bd72b1f8 on epic/modal-pager
              Requires 3 more approvals from Devs, Deployers, and QA.
              Rami Albatal
              Rami Albatal
              Marcelo Rivera
              Marcelo Rivera
              Ben Hayward
              Ben Hayward
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Depends on 1 merge request being merged
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1737

              Deletes source branch

              • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 4 days ago

                added scoped label

              • Emiliano Balbuena @edgebal mentioned in merge request engine!437 4 days ago

                mentioned in merge request engine!437

              • Emiliano Balbuena @edgebal changed the description 4 days ago

                changed the description

              • Bill Ottman
                Bill Ottman :dragon_face: @ottman · 4 days ago
                Owner

                Excited for this @edgebal :)

              • Emiliano Balbuena @edgebal added 2 commits 4 days ago

                added 2 commits

                • 77c2ee0c - (fix): Re-set correct url when closing media modal after navigating
                • 144389d7 - (fix): Set correct blog permalink

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 4 days ago

                added 1 commit

                • e6fe8635 - (feat): Keyboard navigation + esc key handling

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 4 days ago

                added 1 commit

                • a8729b07 - (feat): Change dimensions on-the-fly when video metadata is loaded

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 4 days ago

                added 1 commit

                • 3a92f989 - (chore): Add feature flag

                Compare with previous version

              • Emiliano Balbuena @edgebal added 10 commits 3 days ago

                added 10 commits

                • 3a92f989...1c8ee565 - 8 commits from branch master
                • d6e85f23 - Merge remote-tracking branch 'origin/master' into epic/modal-pager
                • a0cf2bb6 - (refactor): ditch redirectUrl and handle URL hot-swap on modal

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 3 days ago

                changed the description

              • Emiliano Balbuena @edgebal added Status::BuddyReview scoped label 3 days ago

                added scoped label

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 3 days ago

                assigned to @benhayward.ben

              • Emiliano Balbuena @edgebal unmarked as a Work In Progress 3 days ago

                unmarked as a Work In Progress

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 4 hours ago
                Resolved by Ben Hayward 10 minutes ago
              • Emiliano Balbuena @edgebal added 6 commits 1 hour ago

                added 6 commits

                • a0cf2bb6...1181bc82 - 4 commits from branch master
                • e26eefec - Merge remote-tracking branch 'origin/master' into epic/modal-pager
                • bd72b1f8 - (chore): JSdoc

                Compare with previous version

              • Emiliano Balbuena @edgebal resolved all threads 1 hour ago

                resolved all threads

              • Ben Hayward @benhayward.ben resolved all threads 10 minutes ago

                resolved all threads

              Please register or sign in to reply
              2 Assignees
              Emiliano Balbuena's avatar
              Ben Hayward's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::BuddyReview
              Lock merge request
              Unlocked
              12
              12 participants
              user avatar
              Rami Albatal
              user avatar
              Marcelo Rivera
              user avatar
              Ben Hayward
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              user avatar
              Martin Santangelo
              Reference: minds/front!716

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback