Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 348
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !719

Open
Opened 2 days ago by Ben Hayward@benhayward.ben
Report abuse

Added find group button to sidebar #2379

  • Overview 2
  • Commits 2
  • Pipelines 2
  • Changes 5

Summary

Closes #2379

3 things

  • Add a Find a Group button to the groups sidebar linking to discovery.
  • Make Cypress login a data attribute in Cypress
  • Fixes a 1px misalignment for icons (the + and Find a Group)in the groups sidebar.

Steps to test

Simple one,

  1. Log in
  2. Click new button on sidebar
  3. Check URL is correct

I've tested this with more than 12 groups.

image

Estimated Regression Scope

Not a huge change, not much scope for regression but I'd check the sidebar still functions as intended and the discovery URL is correct.

Request to merge feat/find-group-button-2379 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #108965829 passed with warnings for 179bc553 on feat/find-group-button-2379
              Requires approval from Deployers. Approved by
              Xander Miller
              Xander Miller
              Rami Albatal
              Rami Albatal
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2379

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 2 days ago

                added scoped labels

              • Xander Miller @xander-miller approved this merge request 2 days ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 2 days ago
                Developer

                Looks Good.

                image

              • Mark Harding @markeharding approved this merge request 10 hours ago

                approved this merge request

              • Mark Harding @markeharding added Status::Ready to Merge scoped label and automatically removed Status::BuddyReview label 10 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label and automatically removed Status::Ready to Merge label 4 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 3 hours ago

                added 1 commit

                • 179bc553 - Added data-attribute for E2E

                Compare with previous version

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 2 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben assigned to @xander-miller, @edgebal, and @brianhatchet 2 hours ago

                assigned to @xander-miller, @edgebal, and @brianhatchet

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 hours ago
                Developer

                Spotted a regression, the groups E2E tests were failing because over the weekend it appears we've defaulted the sandboxes homepage to the new homepage.

                Last commit just added a data attribute to the login button on and reverted some changes in cypress commands.js

              • Ben Hayward @benhayward.ben unassigned @brianhatchet and @xander-miller 2 hours ago

                unassigned @brianhatchet and @xander-miller

              • Xander Miller @xander-miller approved this merge request 52 minutes ago

                approved this merge request

              Please register or sign in to reply
              Assignee
              Emiliano Balbuena's avatar
              Emiliano Balbuena @edgebal
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              user avatar
              Martin Santangelo
              Reference: minds/front!719

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback