Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 264
  • Merge Requests 27
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !423

Merged
Opened 1 month ago by Marcelo Rivera@eiennohi
Report abuse

Onboarding

  • Overview 9
  • Commits 18
  • Pipelines 10
  • Changes 9
0/5 threads resolved

closes front#2112 (closed)

depends on front!674 (merged)

based off !395 (closed)

Edited 1 month ago by Marcelo Rivera
Request to merge feat/onboarding into master
Pipeline #106595389 failed for a80bdbf9 on feat/onboarding
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Olivia Madrid
          Olivia Madrid
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Guy Thouret
          Guy Thouret

          Merged by Mark Harding 11 minutes ago

          The changes were merged into master with 26263a2f

          The source branch has been deleted

          Closed front#2112 (closed)

          Pipeline #108830650 waiting for manual action for 26263a2f on master
                        • Marcelo Rivera @eiennohi changed milestone to %Onboarding #rollout 1 month ago

                          changed milestone to %Onboarding #rollout

                        • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 month ago

                          added scoped label

                        • Marcelo Rivera @eiennohi mentioned in merge request !395 (closed) 1 month ago

                          mentioned in merge request !395 (closed)

                        • Marcelo Rivera @eiennohi changed title from Feat/onboarding to Onboarding 1 month ago

                          changed title from nboarding to nboarding

                        • Marcelo Rivera @eiennohi changed the description 1 month ago

                          changed the description

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • d0ad2a25 - (feat): homepage feature flag

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • b4535635 - (feat): homepage feature flag

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 45 commits 3 weeks ago

                          added 45 commits

                          • b4535635...b579cbda - 44 commits from branch master
                          • ab04b23f - Merge remote-tracking branch 'upstream/master' into feat/onboarding

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • 3c7c9bac - (feat): updated feature flags

                          Compare with previous version

                        • Xander Miller
                          Xander Miller @xander-miller · 3 weeks ago
                          Developer

                          On my Todo for Approval. Not marked for review no action taken.

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • 1e95a46e - (feat): tweak onboarding progress so we can decide when to show it

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • a0b8ed47 - (fix): update feature flags

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • ad3cd7fa - (fix): should NOT show onboarding if it was shown

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label 3 weeks ago

                          added scoped label

                        • Marcelo Rivera
                          Marcelo Rivera @eiennohi · 3 weeks ago
                          Developer

                          just updated the label @xander-miller

                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                            Developer
                            • The spacing below and above the wired quote does not match the original designs. Please adjust to match designs.

                            Comparison

                            Screenshot_2019-12-19_at_13.56.45

                          • Please register or sign in to reply
                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                            Developer
                            • The heading size does not match original designs.

                            See comparison bellow.

                            Screenshot_2019-12-19_at_13.58.29

                          • Please register or sign in to reply
                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                            Developer
                            • The text below isn't formatted correctly. Please compare with o

                            Screenshot_2019-12-19_at_14.03.27

                            original

                            Screenshot_2019-12-19_at_14.08.45

                          • Please register or sign in to reply
                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                            Developer
                            • Content should be aligned on the left side. Please refer to original design

                            Current State Screenshot_2019-12-19_at_13.48.21

                            Original design Screenshot_2019-12-19_at_13.49.02

                          • Please register or sign in to reply
                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                            Developer
                            • The phone size (large) does not match designs.

                            Please see comparison below.

                            phone_size

                          • Please register or sign in to reply
                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • dda2b619 - (fix): check onboarding feature flag in onboarding/progress.php

                          Compare with previous version

                        • Xander Miller
                          Xander Miller @xander-miller · 3 weeks ago
                          Developer

                          What URL do I use to test this page? Do I have to flip a feature flag when testing it on the sandbox?

                        • Marcelo Rivera
                          Marcelo Rivera @eiennohi · 3 weeks ago
                          Developer

                          Just enabled the feature flags. If you're logged off and go to https://feat-onboarding.minds.io , you'll see the new homepage

                        • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                          added 1 commit

                          • a80bdbf9 - (fix): check onboarding feature flag in onboarding/progress.php

                          Compare with previous version

                        • Mark Harding @markeharding approved this merge request 12 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding merged 11 minutes ago

                          merged

                        • Mark Harding @markeharding mentioned in commit 26263a2f 11 minutes ago

                          mentioned in commit 26263a2f

                        Please register or sign in to reply
                        0 Assignees
                        None
                        Onboarding #rollout
                        Milestone
                        Onboarding #rollout
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        Squad::Yellow Status::Awaiting Review
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Martin Santangelo
                        user avatar
                        Olivia Madrid
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Rami Albatal
                        user avatar
                        Guy Thouret
                        user avatar
                        Brian Hatchet
                        user avatar
                        Ben Hayward
                        Reference: minds/engine!423

                        Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                        More information and share feedback