Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 342
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !719

Open
Opened 16 hours ago by Ben Hayward@benhayward.ben
Report abuse

Added find group button to sidebar #2379

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 5

Summary

Closes #2379

3 things

  • Add a Find a Group button to the groups sidebar linking to discovery.
  • Make Cypress login a data attribute in Cypress
  • Fixes a 1px misalignment for icons (the + and Find a Group)in the groups sidebar.

Steps to test

Simple one,

  1. Log in
  2. Click new button on sidebar
  3. Check URL is correct

I've tested this with more than 12 groups.

image

Estimated Regression Scope

Not a huge change, not much scope for regression but I'd check the sidebar still functions as intended and the discovery URL is correct.

Request to merge feat/find-group-button-2379 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #108523084 passed with warnings for f90d97ca on feat/find-group-button-2379
              Requires approval from Deployers. Approved by
              Xander Miller
              Xander Miller
              Martin Santangelo
              Martin Santangelo
              Olivia Madrid
              Olivia Madrid
              Marcelo Rivera
              Marcelo Rivera
              Juan Manuel Solaro
              Juan Manuel Solaro
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2379

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 16 hours ago

                added scoped labels

              • Xander Miller @xander-miller approved this merge request 15 hours ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 15 hours ago
                Developer

                Looks Good.

                image

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::BuddyReview
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Martin Santangelo
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              Reference: minds/front!719

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback