https://token-onboarding-2331.minds.io/v2wallet

See epic &80 for links to all mockups.

As a disclaimer, this is not intended to be a final draft. There are all sorts of things that need to be cleaned up, there's no need to spend time communicating them to me at this juncture - please assume I am aware of the obvious glitches.

What's inside

Most of the new stuff in here is related to token onboarding #2331. I've successfully gone through the onboarding steps (phone verification + on-chain address setup) locally.

You'll also see lots of things that are under construction , either because I haven't gotten to it yet or because the UX mockups have been in a state of flux. Here are my issues on the UX board.

Issues that have been started and for various reasons are less 'complete' than token onboarding include:

• token settings #2057
• transfer to on-chain modal #2367
• Ether settings #2344

Testing twilio

To test the phone verification step in the token onboarding process locally, you need to make some backend changes.

• in settings.php,

$CONFIG->set('twilio', [
  'account_sid' => '',//get this from Mark
  'auth_token' => '',//get this from Mark
  'from' => '+15005550006' // use this exact number
]);

• in Core/Rewards/Join.php, go to the verify() function
  • directly after this line (around 116): $code = $this->twofactor->getCode($secret);, add error_log($code)
  • comment this line (around 120): throw new \Exception('voip phones not allowed');
  • now when you enter almost any phone number in token onboarding, the corresponding verification code will appear in your php logs. Use it to complete the phone verification step. Note: the handful of phone numbers that won't work are the magic 'To' numbers listed in Twilio's test credential docs.

Testing with fake data

Because of staging limitations you may wish to play around with fake data locally to see what's going on with various currency balances. To populate the fake data, in modules/wallet/v2/dashboard.service.ts uncomment line 79 (this.wallet = fakeData.wallet;).

@eiennohi sorry in advance

added 1 commit

• 442585c6 - (feat): wallet v2 - upate timer

Compare with previous version

changed the description

changed milestone to %Wallet Upgrade

added scoped labels

mentioned in issue docs#23

assigned to @eiennohi

changed target branch from master to epic/wallet-80

Looks like this can only be tested locally at the moment. No action taken.

Just FYI, I had some issues with Twilio locally. This is the log from php-fpm:

fpm_1                           | NOTICE: PHP message: [guard] Twilio error: [HTTP 404] Unable to create record: The requested resource /2010-04-01/Accounts/not set/Messages.json was not found

also, I had to disable phone verification from the backend as it detecting it as a voip phone, for some reason

@omadrid did you have problems like this? maybe I have something misconfigured

also, the code looks fine. It only needs a bit of cleaning up

approved this merge request

unapproved this merge request

The verify code input and buttons are vertically misaligned:

added 15 commits

• 442585c6...c8de38d6 - 14 commits from branch epic/wallet-80
• 381e34cb - Merge remote-tracking branch 'origin/master' into token-onboarding-2331

Compare with previous version

added 2 commits

• b045911f - WIP so I can switch branches for buddy review
• 632e8157 - Enable closing of modal by clicking background

Compare with previous version

marked as a Work In Progress from b045911f

unmarked as a Work In Progress

Scrollbar appears when opening the country dropdown:

If you input a wrong number and press enter, the button gets disabled, but it stays that way after modifying the number:

The component's state should probably reset on ngModelChange, or maybe just don't disable the button if there's something in the input

If you verify your phone number, after closing the modal, there's an issue with the layout where scrollbars disappear and there's a weird stretching effect on the last panel:

here I moved the dev console further down and the graph stretched (might not be that obvious in the screenshot):

added 1 commit

• 15255571 - remove no-scroll class when modal is closed via input from parent component

Compare with previous version

resolved all threads

approved this merge request

merged

mentioned in commit f4b79682