Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 346
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !713

Open
Opened 2 days ago by Ben Hayward@benhayward.ben
Report abuse

Reintroduced maturity selector for activity comments. #2392

  • Overview 3
  • Commits 3
  • Pipelines 3
  • Changes 6
1/1 thread resolved

Summary

Closes #2392

I've re-enabled the maturity filter for comments here, in the same style as we handle it in activities.

Steps to test

Note: if you are the owner, your text is in the show state by default.

  1. Login.
  2. post a non-mature comment on a post.
  3. post a mature comment.
  4. Repeat steps 2 and 3, nesting into the comment tree so that you have 3 tiers of mature and non-mature comments.
  5. Refresh, the posts, they should all be visible as you are the logged-in user.
  6. You should be able to click on the red E icon to blur mature the posts.
  7. Copy the link to the post.

Then,

  1. Log out
  2. Go to the post you made above.
  3. Check the mature text is all blurred.
  4. Click on the text, not the E button to ensure it gets rid of the blur,
  5. Click the text again, it should do nothing.
  6. Click the button again, it should re-blur.
  7. Cycle the button on and off to check it works properly.

Estimated Regression Scope

This change effects comments.

The html-template changes should be self-contained; I don't think they'd affect anything outside of their lines of code by themselves, the only bit of code that really touched anything is in the ngOnInit(), where I check the users guid, and set the content to show if they are the owner of the comment. So, as a worst-case scenario, maybe it would show by default for everybody.

Edited 2 days ago by Ben Hayward
Request to merge fix/explicit-comments-2392 into master
The source branch is 8 commits behind the target branch
Open in Web IDE
Pipeline #107661466 passed with warnings for 02491719 on fix/explicit-comments-2392
              Merge request approved. Approved by
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Rami Albatal
              Rami Albatal
              Guy Thouret
              Guy Thouret
              Marcelo Rivera
              Marcelo Rivera
              Mark Harding
              Mark Harding
              Juan Manuel Solaro
              Juan Manuel Solaro
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2392

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Requires Changes scoped labels 2 days ago

                added scoped labels

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                added 1 commit

                • 4c2a6b9d - Added E2E tests

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                added 1 commit

                • 02491719 - Update comment.component.ts

                Compare with previous version

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 2 days ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 days ago

                unmarked as a Work In Progress

              • Ben Hayward @benhayward.ben changed the description 2 days ago

                changed the description

              • Ben Hayward @benhayward.ben resolved all threads 1 day ago

                resolved all threads

              • Xander Miller @xander-miller approved this merge request 4 hours ago

                approved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 2 hours ago
                Developer

                @benhayward.ben excellent steps to reproduce for a complex interaction that works perfectly.

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 hours ago

                approved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 2 hours ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 2 hours ago
                Developer

                Works like a charm!

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 2 hours ago

                assigned to @benhayward.ben

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              Reference: minds/front!713

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback