Summary

Standarizes the way error are being logged.

Closes #555 (closed).

Steps to test

• Run kubectl get pods | grep goal-error-log-minds-app and take not of the Pod Name.
• Run kubectl logs -f <Pod Name>
• Check for uncaught errors (those that triggers a 500) output in the logs, they should be displayed correctly and with its full trace in a single line.

Note: Xander might not be able to test this, so maybe we should defer QA verification to Mark or Brian.

Estimated Regression Scope

Error logging might be skewed or Sentry reporting for uncaught error might not be triggering.

added scoped label

mentioned in merge request !230 (closed)

added 8 commits

• 0872299a...0819e2e2 - 5 commits from branch master
• 44ba94a6 - (cs): Lint
• d2dece5b - (chore): Unused `use` statement
• 5da4156b - Merge remote-tracking branch 'origin/master' into goal/error-log

Compare with previous version

added 1 commit

• a0823bde - (fix): Rollback composer.lock (upgraded all packages)

Compare with previous version

added 2 commits

• ce960693 - (chore): Code quality
• 9e3324a6 - (proto): Implement Monolog Sentry handler

Compare with previous version

changed the description

added 1 commit

• dbf2693f - (chore): Move static helper; implement singleton

Compare with previous version

resolved all threads

added scoped label

added scoped label and automatically removed label

Documentation:

• PHPDoc header at class-level

added 1 commit

• 95700722 - (cs): PHPDocs

Compare with previous version

unmarked as a Work In Progress

changed the description

added scoped label and automatically removed label

assigned to @benhayward.ben and unassigned @edgebal

added scoped label and automatically removed label

Found a way to trigger a 500.

1. Go to firehose as admin
2. Delete a post
3. Approve it

approved this merge request

Error message looks good to me. Excellent

approved this merge request

Works a treat for me. Just need @xander-miller 's sign off and we're good to go. @xander-miller I can help you with reproducing this if need be.

assigned to @xander-miller and unassigned @benhayward.ben

Do be sure to double-check with Emi before merging as last I heard there was a question still pending to Mark

@markeharding Can you check Ben's screenshot above (!428 (comment 268353933))? It seems like review sites nginx output looks different than production.

@edgebal I think we are good to merge in and see whats happening on staging

approved this merge request

merged

mentioned in commit 00c62ae6

Merging into Staging.