Use media modal in channel media feeds
closes #2226 (closed)
added scoped labels
![Brian Hatchet](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Developer$CONFIG->max_video_length = 12600; $CONFIG->max_video_file_size = 4294967296; $CONFIG->max_daily_boost_views = 10000;
This pod has the default values coming from helm. There's something up with the attachment service. How are you testing these videos on review sites
![Marcelo Rivera](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperI will address this tomorrow. I didn't actually test videos in the sandbox
- Resolved by Marcelo Rivera
added scoped label and automatically removed label
assigned to @eiennohi
added 1 deleted label
- DeveloperResolved by Marcelo Rivera
This works on the review site now, but you still need to address @markeharding 's comment @eiennohi
- Owner
We need to merge in master and confirm this works with the latest player.
- Owner
added 33 commits
-
317ddbb8...65da1be5 - 32 commits from branch
master - 1bc00288 - Merge remote-tracking branch 'upstream/master' into feat/modal-in-media-feeds-2226
-
317ddbb8...65da1be5 - 32 commits from branch
- Developer
@markeharding just updated and it works fine for me
added scoped label and automatically removed label
- Resolved by Marcelo Rivera
- Resolved by Marcelo Rivera
added scoped label and automatically removed label
added scoped label and automatically removed label
added 13 commits
-
55f7fa87...c8de38d6 - 12 commits from branch
master - f8be56ae - Merge remote-tracking branch 'upstream/master' into feat/modal-in-media-feeds-2226
-
55f7fa87...c8de38d6 - 12 commits from branch
- Resolved by Marcelo Rivera
added scoped label and automatically removed label
added scoped label and automatically removed label
- Last updated by Brian Hatchet
26 26 margin: 4px; 27 27 overflow: hidden; 28 28 transform-style: preserve-3d; 29 cursor: pointer; - Owner
These tiles still need to be links but use the modal as first priority.
- Owner
This is vital for SEO and web crawling
- Developer
Please, use threads so we can resolve this comments.
@eiennohi moving this back to requires changes
- Developer
Sorry. Just fixed
- Developer
Verified these tiles are links with the cursor icon
added scoped label and automatically removed label
added scoped label and automatically removed label
approved this merge request
approved this merge request
approved this merge request
merged
mentioned in commit 1c8ee565
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
