Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 350
  • Merge Requests 59
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !710

Merged
Opened 5 days ago by Ben Hayward@benhayward.ben
Report abuse

Group membership change propegation

  • Overview 7
  • Commits 3
  • Pipelines 3
  • Changes 6
4/4 threads resolved

Summary

Closes #2228 (closed)

This MR makes it so that when joining, leaving, creating and destroying a group, the sidebar updates without the user having to refresh.

Steps to test

Create and Delete
  1. Log in.
  2. Create a new group.
  3. Check the sidebar has the new group without you having to reload.
  4. Delete the group, it should now be gone.
Leave and Join
  1. Join a group that you are not an admin of.
  2. Leave the group - it should now be gone from the sidebar.
  3. Rejoin, it should be back.

Estimated Regression Scope

GroupsService, The group sidebar have been the main focus of this change, most of the logical changes are in there.

I've also touched two other areas due to errors flooding my console when testing:

Avatar component, the only change is an extra condition in an if statement, so I don't see much of an issue with that but note it has been touched.

Other than that some changeDetection was added to the videochat component.

Request to merge fix/group-membership-propegation-2228 into master
Pipeline #107384196 passed with warnings for ee302228 on fix/group-membership-propegation-2228
              Merge request approved. Approved by
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Marcelo Rivera
              Marcelo Rivera
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Mark Harding
              Mark Harding

              Merged by Xander Miller 48 minutes ago

              The changes were merged into master with df2e25e3

              The source branch has been deleted

              Closed #2228 (closed)

              Pipeline #108200024 running for df2e25e3 on master
                            • Ben Hayward @benhayward.ben added Squad::Yellow Status::Requires Changes scoped labels 5 days ago

                              added scoped labels

                            • Ben Hayward
                              Ben Hayward @benhayward.ben started a thread on the diff 5 days ago
                              Resolved by Brian Hatchet 1 day ago
                            • Ben Hayward
                              Ben Hayward @benhayward.ben started a thread on the diff 5 days ago
                              Resolved by Brian Hatchet 3 days ago
                            • Ben Hayward @benhayward.ben added 7 commits 3 days ago

                              added 7 commits

                              • f0812700...52608901 - 6 commits from branch master
                              • 20ca45a7 - Merge branch 'master' of gitlab.com:minds/front into fix/group-membership-propegation-2228

                              Compare with previous version

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 3 days ago
                              Resolved by Brian Hatchet 1 day ago
                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 3 days ago
                              Resolved by Brian Hatchet 1 day ago
                            • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                              added 1 commit

                              • ee302228 - Update sidebar-markers.component.ts

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet resolved all threads 1 day ago

                              resolved all threads

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 1 day ago

                              added scoped label and automatically removed label

                            • Xander Miller @xander-miller approved this merge request 48 minutes ago

                              approved this merge request

                            • Xander Miller @xander-miller merged 48 minutes ago

                              merged

                            • Xander Miller @xander-miller mentioned in commit df2e25e3 48 minutes ago

                              mentioned in commit df2e25e3

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            Squad::Yellow Status::Awaiting Review
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Rami Albatal
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Guy Thouret
                            user avatar
                            Mark Harding
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            Reference: minds/front!710

                            Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                            More information and share feedback