(cache)Surge token deletion on logout #1270 (!436) · Merge Requests · Minds / Minds Backend - Engine · GitLab

Surge token deletion on logout #1270

0/1 thread resolved

Summary

Closes #1270

Currently on the mobile app if you log into one account, then log out and into a different account, you will still receive push notifications for the first account.

This is because the Surge tokens (used for push notifications) that we use on the backend are not deleted on logout.

Steps

To hammer out with @brianhatchet and @msantang78. This is going to likely be tricky to test as we do not digest push notifications on the front-end, just the mobile app. This may require us using a manual build of the app and plugging it into the associated sandbox.

I would recommend testing sessions and account swapping/triggering notifications.

Regression Scope

Changes v Impact

api/v1/notifications - Simple change, setting the token on notif POST (from mobile).
Session\Manager - limited to the destroy functionality, so would affect anything that destroys a session (e.g. logging out).
Entities\User - added functions and an exported value, I don't foresee any issues here.

### Summary

Closes #1270

Currently on the mobile app if you log into one account, then log out and into a different account, you will still receive push notifications for the first account.

This is because the Surge tokens (used for push notifications) that we use on the backend are not deleted on logout.

### Steps

To hammer out with @brianhatchet and @msantang78. This is going to likely be tricky to test as we do not digest push notifications on the front-end, just the mobile app. This may require us using a manual build of the app and plugging it into the associated sandbox.

I would recommend testing sessions and account swapping/triggering notifications.

### Regression Scope

Changes v Impact

* api/v1/notifications - Simple change, setting the token on notif POST (from mobile).
* Session\Manager - limited to the destroy functionality, so would affect anything that destroys a session (e.g. logging out).
* Entities\User - added functions and an exported value, I don't foresee any issues here.

Request to merge fix/logout-surge-token-deletion-1270 into master

Open in Web IDE

Ben Hayward @benhayward.ben added Squad::Yellow Status::Blocked scoped labels 23 hours ago

added scoped labels
Ben Hayward @benhayward.ben · 23 hours ago

Developer

Set to blocked pending chat with Brian and Martin.
Ben Hayward @benhayward.ben assigned to @brianhatchet, @msantang78, and @benhayward.ben 23 hours ago

assigned to @brianhatchet, @msantang78, and @benhayward.ben
Brian Hatchet @brianhatchet · 23 hours ago

Developer
Testing on the app requires two things that we don't have.

An ability to change the base url in the app for testing purposes.

The ability to push notifications from the review sites.

So, let's add some logging to show the push notifications going out so we can verify the body of the notification. Once we're sure the logging works, we'll verify it on staging
Brian Hatchet @brianhatchet added Status::BuddyReview scoped label and automatically removed Status::Blocked label 23 hours ago

added scoped label and automatically removed label

Ben Hayward @benhayward.ben started a thread on the diff 1 hour ago

Controllers/api/v1/notifications.php

                     'service' => $service,
                     'token' => $passed_token
                 ]);
                 Core\Session::getLoggedInUser()
                     ->setSurgeToken($token)
                     ->save();

Please register or sign in to reply