Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 350
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 60
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1737

Closed
Open
Opened 4 months ago by Olivia Madrid@omadrid
Report abuse New issue

Modal pager for all content

The media modal needs to load all of our entities - video, images, blogs, activities

When we're loading the modal pager from a feed, the modal pager needs to move left and right through the selected feed.

When we're loading the modal pager from a url directly, the modal pager needs to move left and right through the channel who owns the content.

Add left and right arrows to the media view, loading the appropriate feed.

If the user loads the media view from the feed, the left and right arrows should swipe through the news feed

If the user loads the media view from the channel feed, the left and right arrows should swipe the the channel feed

If the user loads the media view from the group feed, the left and right arrows should swipe through the group feed.

The media modal should load with the settings from discovery and use the hashtags,

Edited 2 weeks ago by Brian Hatchet

Related issues
0

Related merge requests
1
  • WIP: Modal pager
    !716
    Avatar for Emiliano Balbuena
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 6
  • Designs 0
  • Olivia Madrid @omadrid assigned to @omadrid 4 months ago

    assigned to @omadrid

  • Olivia Madrid @omadrid added Squad::Blue scoped label 4 months ago

    added scoped label

  • Olivia Madrid @omadrid added Product::Media scoped label 4 months ago

    added scoped label

  • Olivia Madrid @omadrid changed the description 4 months ago

    changed the description

  • Olivia Madrid @omadrid added 1 deleted label 4 months ago

    added 1 deleted label

  • Mark Harding @markeharding added 1 deleted label 3 months ago

    added 1 deleted label

  • Mark Harding @markeharding removed milestone 3 months ago

    removed milestone

  • Mark Harding @markeharding changed milestone to %Misc. Q4 2019 3 months ago

    changed milestone to %Misc. Q4 2019

  • Mark Harding @markeharding added 1 deleted label and removed 1 deleted label 3 months ago

    added 1 deleted label and removed 1 deleted label

  • Mark Harding @markeharding added 1 deleted label and removed 1 deleted label 3 months ago

    added 1 deleted label and removed 1 deleted label

  • Mark Harding @markeharding removed 1 deleted label 3 months ago

    removed 1 deleted label

  • Mark Harding @markeharding added Status::Validation scoped label 3 months ago

    added scoped label

  • Mark Harding @markeharding changed title from (feat): Modal pager to Modal pager 3 months ago

    changed title from Modal pager to Modal pager

  • Mark Harding @markeharding added Type::Feature scoped label 3 months ago

    added scoped label

  • Mark Harding @markeharding added Status::Planning Breakdown scoped label and automatically removed Status::Validation label 3 months ago

    added scoped label and automatically removed label

  • Mark Harding @markeharding mentioned in issue engine#1011 (closed) 2 months ago

    mentioned in issue engine#1011 (closed)

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 1 month ago
    Owner

    @brianhatchet

  • Brian Hatchet :speech_balloon: @brianhatchet unassigned @omadrid 1 month ago

    unassigned @omadrid

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 3 weeks ago

    added 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Yellow scoped label and automatically removed Squad::Blue label 3 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @edgebal 3 weeks ago

    assigned to @edgebal

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label and automatically removed Status::Planning Breakdown label 3 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
    Developer

    @edgebal Hold off on this one until I talk to @markeharding

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 4 3 weeks ago

    changed weight to 4

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 4h 3 weeks ago

    changed time estimate to 4h

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 1d 4h 2 weeks ago

    changed time estimate to 1d 4h

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 12 2 weeks ago

    changed weight to 12

  • Brian Hatchet :speech_balloon: @brianhatchet removed 1 deleted label 2 weeks ago

    removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::12/25 Wan Wren scoped label 2 weeks ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed title from Modal pager to Modal pager for all content 2 weeks ago

    changed title from Modal pager to Modal pager

  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 2 weeks ago

    changed the description

  • Emiliano Balbuena @edgebal mentioned in issue engine#762 2 weeks ago

    mentioned in issue engine#762

  • Emiliano Balbuena @edgebal added Status::InProgress scoped label and automatically removed Status::Backlog label 1 week ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/01 - Xerothermic Xenarthra scoped label and automatically removed Sprint::12/25 Wan Wren label 1 week ago

    added scoped label and automatically removed label

  • Emiliano Balbuena @edgebal removed Status::InProgress label 1 day ago

    removed label

  • Emiliano Balbuena @edgebal added Status::InProgress scoped label 15 hours ago

    added scoped label

  • Emiliano Balbuena @edgebal mentioned in merge request !716 15 hours ago

    mentioned in merge request !716

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 14 hours ago
    Developer
    • Added back arrows
    • Created a PoC for an Horizontal Feed service which will get previous/next entries based on certain context. For now we just have container which will fetch the neighbour entities on a container based on a timestamp.
    • Modified media modal to allow changing entities on-the-fly
  • Emiliano Balbuena @edgebal added 4h of time spent at 2020-01-09 14 hours ago

    added 4h of time spent at 2020-01-09

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 14 hours ago
    Developer

    Adding the 2 hours spent trying to pass a reference to FeedService (old implementation).

  • Emiliano Balbuena @edgebal added 2h of time spent at 2020-01-09 14 hours ago

    added 2h of time spent at 2020-01-09

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 14 hours ago
    Developer

    Remaining tasks:

    • Ensure we're setting the right permalink URL for blogs
    • Fix wrong URL being set when closing the modal
    • Allow user to press left/right keyboard arrows to navigate
    • Ensure video ratio/sizing is not broken
    • Ensure nothing is broken on Pro channels
    • (Maybe?) Implement a RxJS cursor and fetch bigger datasets from the server for better/faster UX
    • (Maybe?) Increase arrows visibility
    • (Maybe?) Either ignore blogs, or make blog links on newsfeed open on a modal for a consistent behavior
    • (Maybe?) Implement the arrows on the standalone media pages
    Edited by Emiliano Balbuena 1 hour ago
  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 14 hours ago
    Developer

    @brianhatchet @markeharding:

    Please check the (Maybe?) points for feasibility based on deadlines?

    Edited by Emiliano Balbuena 14 hours ago
Please register or sign in to reply
Assignee
Emiliano Balbuena's avatar
Emiliano Balbuena @edgebal
none
Epic
None
Misc. Q4 2019
Milestone
Misc. Q4 2019
Time tracking
Spent 6h
Est 1d 4h
None
Due date
None
5
Labels
Product::Media Sprint::01/01 - Xerothermic Xenarthra Squad::Yellow Status::InProgress Type::Feature
12
Weight
12
Confidentiality
Not confidential
Lock issue
Unlocked
6
6 participants
user avatar
Emiliano Balbuena
user avatar
Brian Hatchet
user avatar
Bill Ottman
user avatar
Mark Harding
user avatar
Olivia Madrid
user avatar
Nicholas Lewis
Reference: minds/front#1737