(cache)Plyr throwing exceptions. Can we catch? (#2377) · Issues · Minds / Minds Frontend

added scoped labels

Useful links:

added scoped label

Discussed in meeting just now,

Emi pointed out the error is in a promise in their code, so we cannot catch it.

First step I'm going to look into whether there is a config option to silence the errors. Second step I'm going to post on Playrs Github/Gitlab.

If we still cannot silence the errors, we plan to look into whitelisting in Sentry.

added scoped label

I think this could be an issue with the Plyr wrapper, ngx-plyr, though the error does explicitly occur within the core Plyr package. I am going to spend a further 30 minutes looking at whether it could be a misconfiguration issue.

added 30m of time spent at 2020-01-06

https://sentry.io/organizations/minds-inc/issues/1177357869/

May be solvable as that isn't too similar to the rest of the errors there. https://github.com/sampotts/plyr/issues/331

mentioned in merge request !712

added 3h of time spent at 2020-01-06

added scoped label and automatically removed label

Please do not close this card with the above MR.

added scoped label and automatically removed label

I did go ahead and get my own local working version of Sentry, and with help from Brian worked out that we should be able to use the handleError, ignoreError or beforeSend. Unfortunately, the error jumps over all of these, as its being bounced to the main angular error handled.

Relevant GitHub https://github.com/getsentry/sentry-javascript/issues/2169#issuecomment-525722319Unfortunat

In terms of if we do get a filter system to work, the errors above are different, and we don't want to blanket ignore all errors of these types:

So what we would have to do is suppress all errors originating from plyr, even if they're useful to us.

At the moment I'm digging around and trying to get a hook into Sentry before the XHR sends, so that I can interrupt it and add this filter.

added 2h of time spent at 2020-01-08

Plyr throwing exceptions. Can we catch?

Related issues 0

Related issues
0