Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 262
  • Merge Requests 28
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !436

Open
Opened 6 minutes ago by Ben Hayward@benhayward.ben
Report abuse

Surge token deletion on logout #1270

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 5

Summary

Closes #1270

Currently on the mobile app if you log into one account, then log out and into a different account, you will still receive push notifications for the first account.

This is because the Surge tokens (used for push notifications) that we use on the backend are not deleted on logout.

Steps

To hammer out with @brianhatchet and @msantang78. This is going to likely be tricky to test as we do not digest push notifications on the front-end, just the mobile app. This may require us using a manual build of the app and plugging it into the associated sandbox.

I would recommend testing sessions and account swapping/triggering notifications.

Regression Scope

Changes v Impact

  • api/v1/notifications - Simple change, setting the token on notif POST (from mobile).
  • Session\Manager - limited to the destroy functionality, so would affect anything that destroys a session (e.g. logging out).
  • Entities\User - added functions and an exported value, I don't foresee any issues here.
Request to merge fix/logout-surge-token-deletion-1270 into master
Open in Web IDE
Pipeline #107889461 running for 8954440c on fix/logout-surge-token-deletion-1270
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena
          Emiliano Balbuena
          Guy Thouret
          Guy Thouret
          Rami Albatal
          Rami Albatal
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Deletes source branch

          • Ben Hayward @benhayward.ben added Squad::Yellow Status::Blocked scoped labels 6 minutes ago

            added scoped labels

          • Ben Hayward
            Ben Hayward @benhayward.ben · 6 minutes ago
            Developer

            Set to blocked pending chat with Brian and Martin.

          • Ben Hayward @benhayward.ben assigned to @brianhatchet, @msantang78, and @benhayward.ben 5 minutes ago

            assigned to @brianhatchet, @msantang78, and @benhayward.ben

          Please register or sign in to reply
          3 Assignees
          Brian Hatchet's avatar
          Martin Santangelo's avatar
          Ben Hayward's avatar
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Yellow Status::Blocked
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Guy Thouret
          user avatar
          Rami Albatal
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          Reference: minds/engine!436

          Now you can access the merge request navigation tabs at the top, where they’re easier to find.

          More information and share feedback