Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 262
  • Merge Requests 27
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !428

Open
Opened 2 weeks ago by Emiliano Balbuena@edgebal
Report abuse

PSR-3 Error logging (Monolog)

  • Overview 16
  • Commits 9
  • Pipelines 6
  • Changes 10
5/5 threads resolved

Summary

Standarizes the way error are being logged.

Closes #555.

Steps to test

  • Run kubectl get pods | grep goal-error-log-minds-app and take not of the Pod Name.
  • Run kubectl logs -f <Pod Name>
  • Check for uncaught errors (those that triggers a 500) output in the logs, they should be displayed correctly and with its full trace in a single line.

Note: Xander might not be able to test this, so maybe we should defer QA verification to Mark or Brian.

Estimated Regression Scope

Error logging might be skewed or Sentry reporting for uncaught error might not be triggering.

Edited 1 day ago by Emiliano Balbuena
Request to merge goal/error-log into master
The source branch is 14 commits behind the target branch
Open in Web IDE
Pipeline #104730190 passed for 95700722 on goal/error-log
          Requires approval from QA. Approved by
          Brian Hatchet
          Brian Hatchet
          Ben Hayward
          Ben Hayward
          Guy Thouret
          Guy Thouret
          Rami Albatal
          Rami Albatal
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #555

          Deletes source branch

          • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 2 weeks ago

            added scoped label

          • Emiliano Balbuena @edgebal mentioned in merge request !230 (closed) 2 weeks ago

            mentioned in merge request !230 (closed)

          • Emiliano Balbuena @edgebal added 8 commits 2 weeks ago

            added 8 commits

            • 0872299a...0819e2e2 - 5 commits from branch master
            • 44ba94a6 - (cs): Lint
            • d2dece5b - (chore): Unused `use` statement
            • 5da4156b - Merge remote-tracking branch 'origin/master' into goal/error-log

            Compare with previous version

            Toggle commit list
          • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

            added 1 commit

            • a0823bde - (fix): Rollback composer.lock (upgraded all packages)

            Compare with previous version

          • Emiliano Balbuena @edgebal added 2 commits 2 weeks ago

            added 2 commits

            • ce960693 - (chore): Code quality
            • 9e3324a6 - (proto): Implement Monolog Sentry handler

            Compare with previous version

          • Emiliano Balbuena @edgebal changed the description 2 weeks ago

            changed the description

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Emiliano Balbuena 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Emiliano Balbuena 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 weeks ago
            Resolved by Emiliano Balbuena 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
            Resolved by Emiliano Balbuena 2 weeks ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 weeks ago
            Resolved by Emiliano Balbuena 2 weeks ago
          • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

            added 1 commit

            • dbf2693f - (chore): Move static helper; implement singleton

            Compare with previous version

          • Emiliano Balbuena @edgebal resolved all threads 2 weeks ago

            resolved all threads

          • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 2 weeks ago

            added scoped label

          • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 2 weeks ago

            added scoped label and automatically removed label

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal · 2 weeks ago
            Developer

            Documentation:

            • PHPDoc header at class-level
            Edited by Emiliano Balbuena 2 weeks ago
          • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

            added 1 commit

            • 95700722 - (cs): PHPDocs

            Compare with previous version

          • Emiliano Balbuena @edgebal unmarked as a Work In Progress 1 day ago

            unmarked as a Work In Progress

          • Emiliano Balbuena @edgebal changed the description 1 day ago

            changed the description

          • Emiliano Balbuena @edgebal added Status::Review scoped label and automatically removed Status::Requires Changes label 1 day ago

            added scoped label and automatically removed label

          • Emiliano Balbuena @edgebal assigned to @benhayward.ben and unassigned @edgebal 1 day ago

            assigned to @benhayward.ben and unassigned @edgebal

          • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label and automatically removed Status::Review label 1 day ago

            added scoped label and automatically removed label

          • Ben Hayward
            Ben Hayward @benhayward.ben · 16 hours ago
            Developer

            image

            Found a way to trigger a 500.

            1. Go to firehose as admin
            2. Delete a post
            3. Approve it
          • Ben Hayward @benhayward.ben approved this merge request 16 hours ago

            approved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 16 hours ago
            Developer

            Error message looks good to me. Excellent

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 16 hours ago

            approved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 16 hours ago
            Developer

            Works a treat for me. Just need @xander-miller 's sign off and we're good to go. @xander-miller I can help you with reproducing this if need be.

          • Brian Hatchet :speech_balloon: @brianhatchet assigned to @xander-miller and unassigned @benhayward.ben 16 hours ago

            assigned to @xander-miller and unassigned @benhayward.ben

          • Ben Hayward
            Ben Hayward @benhayward.ben · 2 hours ago
            Developer

            Do be sure to double-check with Emi before merging as last I heard there was a question still pending to Mark

          • Emiliano Balbuena
            Emiliano Balbuena @edgebal · 1 hour ago
            Developer

            @markeharding Can you check Ben's screenshot above (!428 (comment 268353933))? It seems like review sites nginx output looks different than production.

          Please register or sign in to reply
          Assignee
          Xander Miller's avatar
          Xander Miller @xander-miller
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Yellow Status::Awaiting Review
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Guy Thouret
          user avatar
          Rami Albatal
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Xander Miller
          Reference: minds/engine!428

          Now you can access the merge request navigation tabs at the top, where they’re easier to find.

          More information and share feedback