Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 350
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !713

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
Report abuse

WIP: Reintroduced maturity selector for activity comments. #2392

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 3
0/1 thread resolved

Summary

Closes #2392

I've re-enabled the maturity filter for comments here, in the same style as we handle it in activities.

Steps to test

Note: if you are the owner, your text is in the show state by default.

  1. Login.
  2. post a non-mature comment on a post.
  3. post a mature comment.
  4. Repeat steps 2 and 3, nesting into the comment tree so that you have 3 tiers of mature and non-mature comments.
  5. Refresh, the posts, they should all be visible as you are the logged-in user.
  6. You should be able to click on the red E icon to blur mature the posts.
  7. Copy the link to the post.

Then,

  1. Log out
  2. Go to the post you made above.
  3. Check the mature text is all blurred.
  4. Click on the text, not the E button to ensure it gets rid of the blur,
  5. Click the text again, it should do nothing.
  6. Click the button again, it should re-blur.
  7. Cycle the button on and off to check it works properly.

Estimated Regression Scope

This change effects comments.

The html-template changes should be self-contained; I don't think they'd affect anything outside of their lines of code by themselves, the only bit of code that really touched anything is in the ngOnInit(), where I check the users guid, and set the content to show if they are the owner of the comment. So, as a worst-case scenario, maybe it would show by default for everybody.

Request to merge fix/explicit-comments-2392 into master
Open in Web IDE
Pipeline #107607564 passed with warnings for 9c2544f1 on fix/explicit-comments-2392
              Requires 3 more approvals from Devs, Deployers, and QA.
              Guy Thouret
              Guy Thouret
              Marcelo Rivera
              Marcelo Rivera
              Olivia Madrid
              Olivia Madrid
              Mark Harding
              Mark Harding
              Xander Miller
              Xander Miller
              This is a Work in Progress

              Closes #2392

              Deletes source branch

              You can merge this merge request manually using the
              • Ben Hayward @benhayward.ben added Squad::Yellow Status::Requires Changes scoped labels 1 hour ago

                added scoped labels

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 59 minutes ago
                src/app/modules/comments/comment/comment.component.ts
                112 113 return (this.comment.time_created - secondsElapsed * 0.01) * 1000;
                113 114 })
                114 115 );
                116 console.log(this.comment);
                • Ben Hayward
                  Ben Hayward @benhayward.ben · 59 minutes ago
                  Developer

                  Aware of this one, deploying to sandbox to write the E2E tests.

                • Please register or sign in to reply
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              user avatar
              Xander Miller
              user avatar
              Juan Manuel Solaro
              user avatar
              Brian Hatchet
              Reference: minds/front!713

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback