Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Helm Charts for Minds Projects
Helm Charts for Minds Projects
  • Project overview
  • Repository
  • Issues 0
  • Merge Requests 0
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Helm Charts for Minds ProjectsHelm Charts for Minds Projects
  • Merge Requests
  • !20

Merged
Opened 2 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Onboarding feature flags

  • Overview 15
  • Commits 1
  • Pipelines 1
  • Changes 2
Request to merge feat/onboarding into master
Pipeline #104356268 passed for a360033c on feat/onboarding
    Merge request approved. Approved by
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet

    Merged by Mark Harding 3 hours ago

    The changes were merged into master with c1b2b87a

    The source branch has been deleted

    Pipeline #107509263 passed for c1b2b87a on master
      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • Content should be aligned on the left side. Please refer to original design

        Current State Screenshot_2019-12-19_at_13.48.21

        Original design Screenshot_2019-12-19_at_13.49.02

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • The phone size (large) does not match designs.

        Please see comparison below.

        phone_size

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • The spacing below and above the wired quote does not match the original designs. Please adjust to match designs.

        Comparison

        Screenshot_2019-12-19_at_13.56.45

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • The heading size does not match original designs.

        See comparison bellow.

        Screenshot_2019-12-19_at_13.58.29

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • The text below isn't formatted correctly. Please compare with o

        Screenshot_2019-12-19_at_14.03.27

        original

        Screenshot_2019-12-19_at_14.08.45

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • Please increase spacing here to match original designs.

        Screenshot_2019-12-19_at_14.21.40

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer
        • Positioning and sizing is off here. See overlay below.

        Screenshot_2019-12-19_at_14.26.29

        Edited by Michael Bradley 2 weeks ago
      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        Medium Screen Issues (Screen width @ 900px)

        • The size and positioning of the phone are incorrect. Refer to original design.
        • The 'Join Minds Now' action is not visible at 900px.
        • The download app badges should be in the blue/purple area and not the white.
        • The yellow background graphic becomes skewed as the pages size is reduced. Ideally it should maintain it's original aspect ratio.

        Screenshot_2019-12-19_at_14.34.15

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        Medium Screen Issues (Screen width @ 900px)

        • The logos are not being displayed correctly. Compare with original design.
        • Spacing around the wired quote is incorrect.
        • The general text layout, positioning and sizing is incorrect.

        Screenshot_2019-12-19_at_14.38.05

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        Medium Screen Issues (Screen width @ 900px)

        • The footer layout seems to be broken when the browser is at 900px wide. Please compare with original designs.

        Screenshot_2019-12-19_at_14.40.32

        Edited by Michael Bradley 2 weeks ago
      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        Medium Screen Issues (Screen width @ 900px)

        • The general layout here needs to match original designs. General positioning, font sizes etc are generally wrong.

        Screenshot_2019-12-19_at_14.41.54

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        iPhone X (width ~ 400px wide)

        • Main heading is too large
        • Minds label is too close to the top of the page
        • Size and positioning of phone is incorrect.
        • The Free your mind text block is too narrow. See original designs

        (original left, implementation right)

        Screenshot_2019-12-19_at_14.46.08

        Edited by Michael Bradley 2 weeks ago
      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        iPhone X (width ~ 400px wide)

        • Spacing around the quote is incorrect.
        • The As featured in label can be removed for small devices.
        • General font size, positioning, line spacing can be tweaked to match designs.

        Screenshot_2019-12-19_at_14.49.50

      • Michael Bradley
        Michael Bradley @michaelfbradley · 2 weeks ago
        Developer

        iPhone X (width 400px wide)

        • Footer isn't quite matching the original designs.

        Screenshot_2019-12-19_at_14.55.24

      • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 weeks ago

        approved this merge request

      • Brian Hatchet :speech_balloon: @brianhatchet assigned to @markeharding 2 weeks ago

        assigned to @markeharding

      • Brian Hatchet
        Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
        Developer

        @markeharding Michael commented on the wrong MR. We moved it over to the front. This is just for the feature flags.

      • Mark Harding @markeharding approved this merge request 3 hours ago

        approved this merge request

      • Mark Harding @markeharding merged 3 hours ago

        merged

      • Mark Harding @markeharding mentioned in commit c1b2b87a 3 hours ago

        mentioned in commit c1b2b87a

      Please register or sign in to reply
      Assignee
      Mark Harding's avatar
      Mark Harding @markeharding
      None
      Milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Lock merge request
      Unlocked
      4
      4 participants
      user avatar
      Mark Harding
      user avatar
      Brian Hatchet
      user avatar
      Michael Bradley
      user avatar
      Marcelo Rivera
      Reference: minds/helm-charts!20

      Now you can access the merge request navigation tabs at the top, where they’re easier to find.

      More information and share feedback