Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 254
  • Merge Requests 26
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !433

Open
Opened 1 week ago by Emiliano Balbuena@edgebal
Report abuse

WIP: Modal Page (+ FeedCollection)

  • Overview 4
  • Commits 5
  • Pipelines 4
  • Changes 12
0/4 threads resolved

Summary

TBD (related to a future front MR)

Steps to test

TBD

Estimated Regression Scope

TBD

Request to merge goal/modal-pager into master
The source branch is 7 commits behind the target branch
Open in Web IDE
Pipeline #106236153 failed for 3230977a on goal/modal-pager
          Requires 3 more approvals from Devs, Deployers, and QA.
          Martin Santangelo
          Martin Santangelo
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Guy Thouret
          Guy Thouret
          This is a Work in Progress

          Deletes source branch

          You can merge this merge request manually using the
          • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 1 week ago

            added scoped label

          • Emiliano Balbuena @edgebal added 1 commit 1 week ago

            added 1 commit

            • 09438dd6 - (cs): Lint

            Compare with previous version

          • Emiliano Balbuena @edgebal added 1 commit 1 week ago

            added 1 commit

            • 49e337f3 - (fix): Bring Response::sort() back

            Compare with previous version

          • Emiliano Balbuena @edgebal mentioned in merge request !418 (closed) 1 week ago

            mentioned in merge request !418 (closed)

          • Emiliano Balbuena @edgebal added 1 commit 1 week ago

            added 1 commit

            • 3230977a - (wip): Feeds neighbor endpoint

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 24 minutes ago
            Controllers/api/v2/feeds/neighbor.php
            17
            18 class neighbor implements Interfaces\Api
            19 {
            20 /**
            21 * @inheritDoc
            22 */
            23 public function get($pages)
            24 {
            25 $actor = Session::getLoggedinUser() ?: null;
            26
            27 /** @var FeedCollection $feedCollection */
            28 $feedCollection = Di::_()->get('Feeds\Collection');
            29 $feedCollection
            30 ->setActor($actor);
            31
            32 try {
            • Mark Harding
              Mark Harding @markeharding · 24 minutes ago
              Owner

              we repeat this is lots of places. Helper function?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 24 minutes ago
            Controllers/api/v2/feeds/neighbor.php
            86 ->setAlgorithm($pages[1] ?? '')
            87 ->setType($type)
            88 ->setPeriod($_GET['period'] ?? '12h')
            89 ->setOffset($_GET['offset'] ?? 0)
            90 ->setCap($actor->isAdmin() ? 5000 : 600)
            91 ->setAll((bool) ($_GET['all'] ?? false))
            92 ->setHashtags($hashtags)
            93 ->setSync((bool) ($_GET['sync'] ?? false))
            94 ->setPeriodFallback(false)
            95 ->setAsActivities((bool)($_GET['as_activities'] ?? true))
            96 ->setQuery(urldecode($_GET['query'] ?? ''))
            97 ->setCustomType($_GET['custom_type'] ?? '')
            98 ->setContainerGuid($_GET['container_guid'] ?? null)
            99 ->setNsfw($nsfw)
            100 ->setAccessIds($accessIds)
            101 ->setSingleOwnerThreshold($singleOwnerThreshold)
            • Mark Harding
              Mark Harding @markeharding · 24 minutes ago
              Owner

              this would be the same as limit?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 24 minutes ago
            Core/Feeds/Elastic/Repository.php
            370 372
            371 373 //
            372 374
            375 if ($opts['from_id']) {
            • Mark Harding
              Mark Harding @markeharding · 24 minutes ago
              Owner

              what is from_id?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 24 minutes ago
            Controllers/api/v2/feeds/neighbor.php
            3 * neighbor
            4 *
            5 * @author edgebal
            6 */
            7
            8 namespace Minds\Controllers\api\v2\feeds;
            9
            10 use Exception;
            11 use Minds\Api\Factory;
            12 use Minds\Core\Di\Di;
            13 use Minds\Core\Feeds\FeedCollection;
            14 use Minds\Core\Session;
            15 use Minds\Helpers\Text;
            16 use Minds\Interfaces;
            17
            18 class neighbor implements Interfaces\Api
            • Mark Harding
              Mark Harding @markeharding · 24 minutes ago
              Owner

              Do we need this endpoint? Why is the frontend not just making use channel feed api?

            • Please register or sign in to reply
          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar
          Emiliano Balbuena @edgebal
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          1
          Labels
          Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Martin Santangelo
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Guy Thouret
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/engine!433

          Now you can access the merge request navigation tabs at the top, where they’re easier to find.

          More information and share feedback