Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 350
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !711

Merged
Opened 19 hours ago by Emiliano Balbuena@edgebal
Report abuse

Fix CSS Grid for Pro channel tiles

  • Overview 2
  • Commits 2
  • Pipelines 2
  • Changes 2

Summary

Fixed an issue that was making the Pro channel media tiles to go beyond the screen width.

Closes #2358 (closed).

Steps to test

  • Log in with a Pro channel, ensure your Pro channel is set to "published" in settings
  • Upload at least 3 videos with a very long post text (more than 300 characters).
  • Go to your channel
  • Mark 2 of the video posts as pinned (using the ribbon icon at the top right)
  • Log out, login with another user
  • Visit the Pro channel, it should not overflow like in #2358 (closed) video

Estimated Regression Scope

Pro channels video/image/blog tiles would look awkward by not occupying around the 50% of the screen viewport.

Edited 16 hours ago by Emiliano Balbuena
Request to merge fix/css-grid-cell-overflow into master
Pipeline #107325256 passed with warnings for 7c193407 on fix/css-grid-cell-overflow
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Martin Santangelo
              Martin Santangelo
              Olivia Madrid
              Olivia Madrid
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Guy Thouret
              Guy Thouret

              Merged by Mark Harding 20 minutes ago

              The changes were merged into master with bf91cea7

              The source branch has been deleted

              Closed #2358 (closed)

              Pipeline #107508493 running for bf91cea7 on master
                            • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 19 hours ago

                              added scoped label

                            • Emiliano Balbuena @edgebal marked as a Work In Progress 19 hours ago

                              marked as a Work In Progress

                            • Emiliano Balbuena @edgebal changed title from (fix): Avoid CSS grid cells overflow on Pro channel list to WIP: Fix CSS Grid for Pro channel tiles 19 hours ago

                              changed title from to

                            • Emiliano Balbuena @edgebal changed the description 19 hours ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 1 commit 19 hours ago

                              added 1 commit

                              • 7c193407 - (fix): Remove CSS grid tiles minimum size constraints

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 16 hours ago

                              changed the description

                            • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 16 hours ago

                              added scoped label

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 16 hours ago
                              Developer

                              Review site deployment failed, even after running review:stop and review:start again.

                              cc/ @brianhatchet

                            • Emiliano Balbuena @edgebal unmarked as a Work In Progress 16 hours ago

                              unmarked as a Work In Progress

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet · 16 hours ago
                              Developer

                              I just deployed the template changes to helm. Using another job as a test. Once that works, I'll reboot these

                            • Mark Harding @markeharding approved this merge request 21 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit bf91cea7 20 minutes ago

                              mentioned in commit bf91cea7

                            • Mark Harding @markeharding merged 20 minutes ago

                              merged

                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            Squad::Yellow Status::Awaiting Review
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Martin Santangelo
                            user avatar
                            Olivia Madrid
                            user avatar
                            Brian Hatchet
                            user avatar
                            Xander Miller
                            user avatar
                            Guy Thouret
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!711

                            Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                            More information and share feedback