Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 351
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #2377

Closed
Open
Opened 2 weeks ago by Mark Harding@markeharding0 of 8 tasks completed0/8 tasks
Report abuse New issue

Plyr throwing exceptions. Can we catch?

These exceptions might be harmless but they are muddying up Sentry and should be caught.

  • https://sentry.io/organizations/minds-inc/issues/1384098907
  • https://sentry.io/organizations/minds-inc/issues/1177357869
  • https://sentry.io/organizations/minds-inc/issues/1384007806
  • https://sentry.io/organizations/minds-inc/issues/1384675732
  • https://sentry.io/organizations/minds-inc/issues/1384120447
  • https://sentry.io/organizations/minds-inc/issues/1384999350
  • https://sentry.io/organizations/minds-inc/issues/1384970051
  • https://sentry.io/organizations/minds-inc/issues/1383435876

Related issues
0

Related merge requests
1
  • Plyr play error
    !712
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 5
  • Designs 0
  • Mark Harding @markeharding added Priority::1 - High Product::Media Type::Bug scoped labels 2 weeks ago

    added scoped labels

  • Mark Harding
    Mark Harding @markeharding · 8 hours ago
    Owner

    Useful links:

    • https://github.com/getsentry/sentry-javascript/issues/2210
    • https://github.com/getsentry/sentry-javascript/issues/424
  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 7 hours ago

    assigned to @benhayward.ben

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/01 - Xerothermic Xenarthra scoped label 7 hours ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Yellow scoped label 7 hours ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet unassigned @markeharding 7 hours ago

    unassigned @markeharding

  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 hours ago
    Developer

    Discussed in meeting just now,

    Emi pointed out the error is in a promise in their code, so we cannot catch it.

    First step I'm going to look into whether there is a config option to silence the errors. Second step I'm going to post on Playrs Github/Gitlab.

    If we still cannot silence the errors, we plan to look into whitelisting in Sentry.

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label 4 hours ago

    added scoped label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 hours ago
    Developer

    I think this could be an issue with the Plyr wrapper, ngx-plyr, though the error does explicitly occur within the core Plyr package. I am going to spend a further 30 minutes looking at whether it could be a misconfiguration issue.

  • Ben Hayward @benhayward.ben added 30m of time spent at 2020-01-06 3 hours ago

    added 30m of time spent at 2020-01-06

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 hours ago
    Developer

    https://sentry.io/organizations/minds-inc/issues/1177357869/

    May be solvable as that isn't too similar to the rest of the errors there. https://github.com/sampotts/plyr/issues/331

  • Ben Hayward @benhayward.ben mentioned in merge request !712 1 hour ago

    mentioned in merge request !712

  • Ben Hayward @benhayward.ben added 3h of time spent at 2020-01-06 1 hour ago

    added 3h of time spent at 2020-01-06

  • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::InProgress label 34 minutes ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 34 minutes ago
    Developer

    Please do not close this card with the above MR.

Please register or sign in to reply
Assignee
Ben Hayward's avatar
Ben Hayward @benhayward.ben
none
Epic
None
None
Milestone
None
Time tracking
Spent: 3h 30m
None
Due date
None
6
Labels
Priority::1 - High Product::Media Sprint::01/01 - Xerothermic Xenarthra Squad::Yellow Status::BuddyReview Type::Bug
None
Weight
None
Confidentiality
Not confidential
Lock issue
Unlocked
3
3 participants
user avatar
Ben Hayward
user avatar
Brian Hatchet
user avatar
Mark Harding
Reference: minds/front#2377