Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 350
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !712

Open
Opened 10 minutes ago by Ben Hayward@benhayward.ben
Report abuse

Plyr play error

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Summary

Part-way to closing #2377

When debugging I noticed errors being thrown from Plyr before the parent components init had succeeded; This raised an alarm bell as media pages should not be auto-playing to start with. The modals should be when they are clicked, but not on a media page.

It appears as though if autoplay is provided as an @input, it tries to auto-play straight away, in turn throwing an error because the component is not ready https://developers.google.com/web/updates/2017/06/play-request-was-interrupted

Steps to test

On production, just open your console and load a video (e.g. the randomly selected https://www.minds.com/media/1060934327732535296)

To test, check this error does not show on the sandbox.

Estimated Regression Scope

I can only foresee the worst-case scenario as being a regression in the auto-playing of videos; perhaps when opening a modal; this is not the case though by my testing.

Request to merge fix/autoplay-bug-2377 into master
Open in Web IDE
Pipeline #107363021 running for 5a8c9b58 on fix/autoplay-bug-2377
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Martin Santangelo
              Martin Santangelo
              Xander Miller
              Xander Miller
              Marcelo Rivera
              Marcelo Rivera
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2377

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 10 minutes ago

                added scoped labels

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::BuddyReview
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Martin Santangelo
              user avatar
              Xander Miller
              user avatar
              Marcelo Rivera
              user avatar
              Olivia Madrid
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              Reference: minds/front!712

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback