Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 353
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1755

Closed
Open
Opened 4 months ago by Nicholas Lewis@javanick
Report abuse New issue

(feat): share specific comments

Users should be able to share a link to specific comments within posts and group chat.

Related issues
0

  • Discussion 5
  • Designs 0
  • Nicholas Lewis @javanick added Priority::2 - Normal Product::Comments Type::Feature scoped labels 4 months ago

    added scoped labels

  • Qriist
    Qriist @Qriist · 4 months ago

    A quick look at the notification link inside Chrome's code console reveals that there is a full url generated from the thread component URNs, which is how it jumps you from the notification list to the specific message.

    This means the backend linking work is already done and all that needs to be done is expose that very same link with a share button.

    Thanks!

  • Chris Cates
    Chris Cates :speech_balloon: @chriscates · 4 months ago

    This is actually a front end related issue too.

    The router component for sharing would need to change in order to accept a query parameter for commentId or something along the lines of this.

    Should also be opened (or related to the front end). All that needs to happen for the backend is an ability to GET a post by commentId.

  • Ben Hayward @benhayward.ben moved from engine#760 (moved) 4 months ago

    moved from engine#760 (moved)

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 months ago
    Developer

    Exactly @Qriist! you can see it in the query string when you click notifications to media.

    Yep, is indeed front-end @chriscates, good spotting that one. I think it should just be a case of dynamically generating a URL in this format, when you guys click a button.

    https://www.minds.com/media/1008238402763268096?focusedCommentUrn=urn:comment:1008238402763268096:1008760152644538368:0:0:1009089798968348672

    All of the data needed should be available within the context of the comment tree.

  • Chris Cates
    Chris Cates :speech_balloon: @chris_at_jadeo · 4 months ago

    @benhayward.ben, in that case what would need to happen is a new "share" icon in the sub menu for comments. This "share" icon would prompt a new "Remind" dialog utilizing the URN format you provided.

    I believe this outlines the requirements for the feature and should be straight forward to the contributor who creates a merge request.

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 18 minutes ago
    Owner

    Closing in favor of engine#915

  • Bill Ottman :dragon_face: @ottman closed 18 minutes ago

    closed

Please register or sign in to reply
0 Assignees
None
none
Epic
None
None
Milestone
None
Time tracking
No estimate or time spent
None
Due date
None
3
Labels
Priority::2 - Normal Product::Comments Type::Feature
None
Weight
None
Confidentiality
Not confidential
Lock issue
Unlocked
6
6 participants
user avatar
Bill Ottman
user avatar
Chris Cates
user avatar
Ben Hayward
user avatar
Chris Cates
user avatar
Qriist
user avatar
Nicholas Lewis
Reference: minds/front#1755