Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 352
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !660

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Swapped out old failing datepicker library

  • Overview 8
  • Commits 6
  • Pipelines 4
  • Changes 13
1/2 threads resolved

Closes #2171

Summary

The old date-picker component was broken (the one that is used on the wallet pages as filters). Swapping out other components to use this format is out of the scope of this MR, but would be worth consideration.

https://github.com/DanielYKPan/date-time-picker - Actively maintained, quite a lot of functionality that's easy to reach (e.g. min and max).

image

Testing

  • Test the date components of the site, make sure they all work as intended.
  • On the schduler, On the wallet page, on the Admin pages.
  • Make sure filters values are respected in relation to the returned transactions.
Edited 4 weeks ago by Ben Hayward
Request to merge fix/date-picker-transactions-2171 into master
The source branch is 47 commits behind the target branch
Open in Web IDE
Pipeline #100621045 passed with warnings for 1cf999d2 on fix/date-picker-transactions-2171
              Requires 3 more approvals from Devs, Deployers, and QA.
              Marcelo Rivera
              Marcelo Rivera
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally

              Closes #2171

              Deletes source branch

              You can merge this merge request manually using the
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 month ago

                added scoped labels

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
                Resolved by Ben Hayward 1 month ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                added 1 commit

                • 5f793ea8 - Removed old package

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 1 month ago

                resolved all threads

              • Ben Hayward @benhayward.ben marked as a Work In Progress 1 month ago

                marked as a Work In Progress

              • Ben Hayward @benhayward.ben changed the description 1 month ago

                changed the description

              • Ben Hayward @benhayward.ben mentioned in issue #2258 1 month ago

                mentioned in issue #2258

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 month ago
                Developer

                Will replace other components in #2258 if you want to do it in one go.

                edit: did it all in this MR

                Edited by Ben Hayward 3 weeks ago
              • Ben Hayward @benhayward.ben added 46 commits 1 month ago

                added 46 commits

                • 5f793ea8...6ad11c19 - 43 commits from branch master
                • 8f0bb3cf - Updated to remove references to old datepicker
                • a52496ac - Merge branch 'master' of gitlab.com:minds/front into fix/date-picker-transactions-2171
                • 10901865 - Updated to change post schedulers and admin filters #2171

                Compare with previous version

                Toggle commit list
              • Ben Hayward @benhayward.ben added 1 commit 4 weeks ago

                added 1 commit

                • 1cf999d2 - Missed CSS file

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 4 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 4 weeks ago

                unmarked as a Work In Progress

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 4 weeks ago

                added scoped label and automatically removed label

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                  Developer

                  Do we want to require the user to click the set button to set the date? Feels like clicking the date and setting the value is the standard behavior for date pickers

                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                  Developer

                  This MR has merge conflicts

                • Ben Hayward
                  Ben Hayward @benhayward.ben · 3 weeks ago
                  Developer

                  Yeah, these cropped up a couple of hours ago. No worries though I think its an easy merge.

                  In terms of do we want to do with hitting set on our date, I am assuming you mean date & time (the date pickers do work like that).

                  I suppose we could probably hook into the on calendar click event, and close the modal, unsure if that would work well or not though, depends if the hook executes before the value is set. Happy to experiment if you like. Hiding the set button I think can be done easy enough through CSS but I don't see a way to disable it otherwise.

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                  Developer

                  Hiding the set button isn't the issue. It's having to click a date and then click set that's too many clicks to do one thing. Leave the control displayed and then see if you can get the date picker closing automatically on date set.

                • Ben Hayward
                  Ben Hayward @benhayward.ben · 13 minutes ago
                  Developer

                  Had quite a bit of trouble doing this, it looks like the author intentionally wrote the picker to not close on date selected when the 'both' option is used (Calendar & Timer).

                  I'm going to try a quick workaround but if that's the case, we will chat about it. Might be a case of forking or abandoning in favor of another picker.

                  https://github.com/DanielYKPan/date-time-picker/issues/72#issuecomment-390372276

                • Please register or sign in to reply
              • Brian Hatchet :speech_balloon: @brianhatchet added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 3 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::Requires Changes label 13 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Follow Up
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Marcelo Rivera
              user avatar
              Xander Miller
              user avatar
              Brian Hatchet
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              Reference: minds/front!660

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback