Email Confirmation
added scoped label
added 1 commit
- 1383a9f0 - (feat): Show banner when email is not confirmed. Handle address update
added 1 commit
- 53486af2 - (fix): Don't use Minds.user when checking changes
unmarked as a Work In Progress
changed the description
changed the description
added 1 commit
- a9ab54d7 - (feat): Don't show banner if coming from email confirmation link
![Xander Miller](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperNot seeing any testing instructions on this one yet. I imagine we are waiting for mailtrap to be set up on the sandboxes.
added scoped label
assigned to @benhayward.ben and unassigned @edgebal
- Developer
@xander-miller Instructions are going to be on engine!424 (merged) (parent MR)
![Ben Hayward](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
DeveloperResolved by Emiliano Balbuena
Providing the above email will not have the red banner and lack of images in production, all good as far as the test goes.
Things to consider in future work
-
Add a failed confirmation message (send 2 emails and click the oldest one, it looks like it worked then refresh and see it did not).
-
I see once you re-send, the resend part of the text disappears from the banner, but never re-appears. This could be given a timer, with a last_requested_time in local storage so a user can't just refresh and spam.
-
- Last reply by Brian Hatchet
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
- Resolved by Emiliano Balbuena
- Developer
!699 (comment 263718217) If we do have some buffer time, I can implement Ben's suggestions.
DeveloperLet's close off this card with doc feedback. We'll revisit Ben's excellent ideas at a later date.
Edited by Brian Hatchetresolved all threads
- Developer
Feedback done!
cc/ @benhayward.ben
assigned to @brianhatchet and @xander-miller and unassigned @benhayward.ben
added scoped label and automatically removed label
- Developer
Moved to Requires Changes due to mobile deeplinking compatibility
added 9 commits
-
9b105d43...ea067e71 - 8 commits from branch
master - 3d02ced0 - Merge remote-tracking branch 'origin/master' into goal/email-verification
-
9b105d43...ea067e71 - 8 commits from branch
added 1 commit
- 4f4e9669 - (chore): Redirect email confirmation URL to root
approved this merge request
mentioned in commit 52608901
merged
