Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 352
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !689

Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](fix): Fixed pro spec test. #2310

  • Overview 5
  • Commits 4
  • Pipelines 4
  • Changes 1
0/1 thread resolved

Closes #2310

To test, check the pipeline down below or checkout this branch locally and run Cypress.

Request to merge fix/pro-marketting-2310 into master
Open in Web IDE
Pipeline #106846187 failed for cc5c6f37 on fix/pro-marketting-2310
              Requires 3 more approvals from Devs, Deployers, and QA.
              Marcelo Rivera
              Marcelo Rivera
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2310

              Deletes source branch

              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

                added scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                Developer

                @benhayward.ben can you explain your comment in the card?

                Pro tests are not supposed to run on sandboxes. I can, however, enable them if we can confirm sandbox & proudction are now running on prod / sandboxes

                We definitely need to get our e2e tests running on review sites for pro. What's the issue?

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 weeks ago
                Developer

                Sorry, may have typed too fast - They were initially skipped over because Pro sites were not working on the sandboxes, which they now are (I believe this was around the time the router changes were going in), so they need re-enabling and likely updating so they greenlight. Made a card for this here but I've left it in follow-up as it needs further breaking up. #2316

                This, however, is actually under the marketing banner so it is unrelated to that anyway, I hadn't realized at the time.

              • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                added 1 commit

                • 07abf688 - Added in location checking

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 weeks ago
                Developer

                Test failing here - I suspect we need to do something with helm to fix the environment so that it passes; we will discuss today.

              • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 3 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 16 commits 3 weeks ago

                added 16 commits

                • 07abf688...2cd5b807 - 15 commits from branch master
                • fb57f8ec - Merge branch 'master' of gitlab.com:minds/front into fix/pro-marketting-2310

                Compare with previous version

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                  Developer

                  Pro marketing e2e tests are still failing

                • Please register or sign in to reply
              • Ben Hayward @benhayward.ben added 28 commits 1 hour ago

                added 28 commits

                • fb57f8ec...52608901 - 27 commits from branch master
                • cc5c6f37 - Merge branch 'master' of gitlab.com:minds/front into fix/pro-marketting-2310

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 hour ago
                Developer

                Updated to master / restarted sandboxes. If this does not work I'll try manually update with helm.

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Marcelo Rivera
              user avatar
              Xander Miller
              user avatar
              Brian Hatchet
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              Reference: minds/front!689

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback