Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 263
  • Merge Requests 28
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !424

Merged
Opened 2 weeks ago by Emiliano Balbuena@edgebal
Report abuse

Email Confirmation

  • Overview 9
  • Commits 17
  • Pipelines 15
  • Changes 23
2/2 threads resolved

Summary

Users should receive a confirmation email to verify it's a real address when signing up or updating the email address.

Testing

  • Go to https://goal-email-verification.minds.io/
  • Create a new user using a REAL email address
  • You should be logged in automatically and a blue banner asking for email confirmation will be shown
  • Reload the page and ensure the banner is still there
  • Check your email inbox (probably on Spam folder, might need to wait a bit). DO NOT CLICK ON THE LINK YET
  • Go back to Minds tab, click on the Re-Send link
  • Ensure you get another email. You might need to wait a couple of minutes.
  • Click on the latest email's "Complete Setup" button
  • Ensure the banner is not being shown on this new opened tab
  • Reload the page and ensure the banner is not appearing

Issues

  • Closes #1229 (closed)
Edited 2 weeks ago by Emiliano Balbuena
Request to merge goal/email-verification into master
Pipeline #105220882 passed for 59438b34 on goal/email-verification
          Merge request approved. Approved by
          Ben Hayward
          Ben Hayward
          Xander Miller
          Xander Miller
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Rami Albatal
          Rami Albatal
          Mark Harding
          Mark Harding

          Merged by Mark Harding 3 hours ago

          The changes were merged into master with a8f2ccf4

          The source branch has been deleted

          Closed #1229 (closed)

          Pipeline #106807287 waiting for manual action for a8f2ccf4 on master
                        • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 2 weeks ago

                          added scoped label

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • bccf0a24 - (fix): Settings keys

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 2 commits 2 weeks ago

                          added 2 commits

                          • 116bac6f - (fix): Missing tracking parameters
                          • 8177aaf2 - (feat): Email Confirmation

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • cbe179c8 - (test): RouterHooksSpec fix

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • f4d604b3 - (refactor): Move delegate to its own class; (test): Spec tests

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • f62e83a5 - (fix): Missing template vars

                          Compare with previous version

                        • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                          changed the description

                        • Emiliano Balbuena @edgebal mentioned in merge request front!699 (merged) 2 weeks ago

                          mentioned in merge request front!699 (merged)

                        • Brian Hatchet
                          Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 2 weeks ago
                          Resolved by Emiliano Balbuena 2 weeks ago
                        • Brian Hatchet
                          Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 2 weeks ago
                          Resolved by Emiliano Balbuena 2 weeks ago
                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • 82d496f3 - (feat): Re-send confirmation email; (feat): Reset when email changes

                          Compare with previous version

                        • Emiliano Balbuena @edgebal resolved all threads 2 weeks ago

                          resolved all threads

                        • Ben Hayward
                          Ben Hayward @benhayward.ben · 2 weeks ago
                          Developer

                          https://streamable.com/ht3pm

                          image

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • eca33f60 - (feat): Export email confirmation status

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • ee7dbe4b - (fix): Template fixes; ditch intermediate queue for confirm email

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 2 commits 2 weeks ago

                          added 2 commits

                          • 237b8a3a - (fix): Disable User cache when sending confirmation email
                          • 89955644 - (fix): Reset email confirmation when changing email

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 12 commits 2 weeks ago

                          added 12 commits

                          • 89955644...bd60d664 - 11 commits from branch master
                          • 936c5d6d - Merge remote-tracking branch 'origin/master' into goal/email-verification

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • fcbe063f - (test): Fix ManagerSpec

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                          added 1 commit

                          • 5ddf644e - (feat): Export when source is email confirmation

                          Compare with previous version

                        • Emiliano Balbuena @edgebal unmarked as a Work In Progress 2 weeks ago

                          unmarked as a Work In Progress

                        • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 2 weeks ago

                          assigned to @benhayward.ben

                        • Brian Hatchet :speech_balloon: @brianhatchet changed the description 2 weeks ago

                          changed the description

                        • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                          changed the description

                        • Xander Miller
                          Xander Miller @xander-miller · 2 weeks ago
                          Developer

                          On my todo list for approval. Not marked for review yet. No action taken.

                        • Juan Manuel Solaro @juanmsolaro mentioned in merge request mobile-native!463 2 weeks ago

                          mentioned in merge request mobile-native!463

                        • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 2 weeks ago

                          added scoped label

                        • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                          changed the description

                        • Emiliano Balbuena @edgebal unassigned @edgebal 1 week ago

                          unassigned @edgebal

                        • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 1 week ago

                          added scoped label and automatically removed label

                        • Emiliano Balbuena
                          Emiliano Balbuena @edgebal · 1 week ago
                          Developer

                          Moved to Requires Changes due to mobile deeplinking compatibility

                        • Martin Santangelo @msantang78 mentioned in merge request mobile-native!467 1 week ago

                          mentioned in merge request mobile-native!467

                        • Emiliano Balbuena @edgebal added 12 commits 1 week ago

                          added 12 commits

                          • 5ddf644e...42417e78 - 11 commits from branch master
                          • 5a100825 - Merge remote-tracking branch 'origin/master' into goal/email-verification

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                          added 1 commit

                          • 59438b34 - (chore): Add path to email confirmation URL

                          Compare with previous version

                        • Emiliano Balbuena @edgebal added 30m of time spent at 2019-12-24 1 week ago

                          added 30m of time spent at 2019-12-24

                        • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 16 hours ago

                          approved this merge request

                        • Xander Miller
                          Xander Miller @xander-miller · 16 hours ago
                          Developer

                          I received the verification email. However

                          • No blue banner for email verification
                          • None of the assets loaded in the email
                          • No banner on reload since no banner initially
                          • No resend email link, was it suppose to be on the blue banner?

                          No assets

                          image

                          No banner

                          image

                          Attempted in both Brave and Chrome

                          Also MR is still labelled requires changes.

                        • Brian Hatchet :speech_balloon: @brianhatchet added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 16 hours ago

                          added scoped label and automatically removed label

                        • Xander Miller @xander-miller approved this merge request 16 hours ago

                          approved this merge request

                        • Ben Hayward @benhayward.ben approved this merge request 15 hours ago

                          approved this merge request

                        • Ben Hayward
                          Ben Hayward @benhayward.ben · 15 hours ago
                          Developer

                          Approved assuming the missing assets will not be an issue on production

                        • Ben Hayward @benhayward.ben assigned to @brianhatchet and unassigned @benhayward.ben 15 hours ago

                          assigned to @brianhatchet and unassigned @benhayward.ben

                        • Ben Hayward @benhayward.ben added Status::Ready to Merge scoped label and automatically removed Status::Awaiting Review label 15 hours ago

                          added scoped label and automatically removed label

                        • Mark Harding @markeharding merged 3 hours ago

                          merged

                        • Mark Harding @markeharding mentioned in commit a8f2ccf4 3 hours ago

                          mentioned in commit a8f2ccf4

                        Please register or sign in to reply
                        Assignee
                        Brian Hatchet's avatar
                        Brian Hatchet @brianhatchet
                        None
                        Milestone
                        None
                        Time tracking
                        Spent: 30m
                        2
                        Labels
                        Squad::Yellow Status::Ready to Merge
                        Lock merge request
                        Unlocked
                        11
                        11 participants
                        user avatar
                        Marcelo Rivera
                        user avatar
                        Guy Thouret
                        user avatar
                        Olivia Madrid
                        user avatar
                        Rami Albatal
                        user avatar
                        Mark Harding
                        user avatar
                        Martin Santangelo
                        user avatar
                        Brian Hatchet
                        Reference: minds/engine!424

                        Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                        More information and share feedback