Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 352
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !683

Open
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Use media modal in channel media feeds

  • Overview 12
  • Commits 4
  • Pipelines 5
  • Changes 2
4/6 threads resolved

closes #2226

Request to merge feat/modal-in-media-feeds-2226 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #106662196 passed with warnings for f8be56ae on feat/modal-in-media-feeds-2226
              Requires 3 more approvals from Devs, Deployers, and QA.
              Martin Santangelo
              Martin Santangelo
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2226

              Deletes source branch

              • Marcelo Rivera @eiennohi added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

                added scoped labels

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                  Developer

                  $CONFIG->max_video_length = 12600; $CONFIG->max_video_file_size = 4294967296; $CONFIG->max_daily_boost_views = 10000;

                  This pod has the default values coming from helm. There's something up with the attachment service. How are you testing these videos on review sites

                • Collapse replies
                • Marcelo Rivera
                  Marcelo Rivera @eiennohi · 3 weeks ago
                  Developer

                  I will address this tomorrow. I didn't actually test videos in the sandbox

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Marcelo Rivera 21 hours ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @eiennohi 3 weeks ago

                assigned to @eiennohi

              • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 3 weeks ago

                added 1 deleted label

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 weeks ago
                  Developer
                  Resolved by Marcelo Rivera 2 weeks ago

                  This works on the review site now, but you still need to address @markeharding 's comment @eiennohi

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding · 3 weeks ago
                Owner

                We need to merge in master and confirm this works with the latest player.

              • Mark Harding
                Mark Harding @markeharding · 2 weeks ago
                Owner

                @eiennohi

              • Marcelo Rivera @eiennohi added 33 commits 2 weeks ago

                added 33 commits

                • 317ddbb8...65da1be5 - 32 commits from branch master
                • 1bc00288 - Merge remote-tracking branch 'upstream/master' into feat/modal-in-media-feeds-2226

                Compare with previous version

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 2 weeks ago
                Developer

                @markeharding just updated and it works fine for me

              • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 2 weeks ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
                Resolved by Marcelo Rivera 21 hours ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 weeks ago
                Resolved by Marcelo Rivera 21 hours ago
              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 2 weeks ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1 commit 21 hours ago

                added 1 commit

                • cf032391 - (fix): added documentation

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 21 hours ago

                added 1 commit

                • 55f7fa87 - (fix): added jsdoc

                Compare with previous version

              • Marcelo Rivera @eiennohi added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 21 hours ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 13 commits 18 hours ago

                added 13 commits

                • 55f7fa87...c8de38d6 - 12 commits from branch master
                • f8be56ae - Merge remote-tracking branch 'upstream/master' into feat/modal-in-media-feeds-2226

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 39 minutes ago
                src/app/modules/newsfeed/feeds/tiles.component.html
                10 10 [ngClass]="{
                11 11 'm-newsfeed-tiles__Tile--is-mature': attachment.shouldBeBlurred(entity)
                12 12 }"
                13 [routerLink]="['/newsfeed', entity.guid]"
                • Mark Harding
                  Mark Harding @markeharding · 39 minutes ago
                  Owner

                  now this is no longer a link it doesn't have a cursor. It also should still probably be a link if possible.

                • Please register or sign in to reply
              • Mark Harding @markeharding added Status::Requires Changes scoped label and automatically removed Status::Awaiting Review label 39 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              Assignee
              Marcelo Rivera's avatar
              Marcelo Rivera @eiennohi
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Martin Santangelo
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Xander Miller
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              Reference: minds/front!683

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback